ci: fix pnpm install change lockfile during ci #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasjhan
requested review from
zustkeeper,
berendsliedrecht and
cre8
as code owners
Signed-off-by: Lukas.J.Han <[email protected]>
|
Or we could commit the lockfile from new version of pnpm |
Closed
|
@lukasjhan from my point I would prefer the newer version approach. frozen-lockfile could generate other side effects. |
Okay I'll change the pr and let you know :) |
This reverts commit f7d2e4a. Signed-off-by: Lukas.J.Han <[email protected]>
This reverts commit d725cac. Signed-off-by: Lukas.J.Han <[email protected]>
This reverts commit 63e9332. Signed-off-by: Lukas.J.Han <[email protected]>
…tion#212)" This reverts commit 984b598. Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
|
@cre8 I reverted the commits for debugging and the vite version. then update the lock file :) |
cre8
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cre8 About #213, How about trying this change?