Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0 #3430

Merged
merged 3 commits into from
Jan 8, 2025
Merged

1.2.0 #3430

merged 3 commits into from
Jan 8, 2025

Conversation

swcurran
Copy link
Contributor

@swcurran swcurran commented Jan 7, 2025

In addition to the usual Release changes, updates a number of Dockerfiles to use the most recent previous release (Release 1.1.0).

One question for OpenAPI experiments. Where do we change, and what is the ramification of changing, the "Title" in the openapi.json and swagger.json files from the current "title" : "Aries Cloud Agent" to a post OWF-move name like ACA-Py Agent. Given it is just "info", does it affect those using the OpenAPI generators?

Thanks!

Signed-off-by: Stephen Curran <[email protected]>
@swcurran swcurran requested review from a team January 7, 2025 19:43
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than those couple typo mistakes Emiliano pointed out.

@jamshale
Copy link
Contributor

jamshale commented Jan 7, 2025

One question for OpenAPI experiments. Where do we change, and what is the ramification of changing, the "Title" in the openapi.json and swagger.json files from the current "title" : "Aries Cloud Agent" to a post OWF-move name like ACA-Py Agent. Given it is just "info", does it affect those using the OpenAPI generators?

I don't think it would effect anything except the output but I'm not positive.

Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
@swcurran
Copy link
Contributor Author

swcurran commented Jan 7, 2025

Maintainers -- we'll hold this PR to merge tomorrow (Jan. 8). Sending an announcement about the LTS update in this release on Discord and leaving a little (but not much) time for feedback.

@swcurran swcurran marked this pull request as draft January 7, 2025 22:03
Copy link

sonarqubecloud bot commented Jan 7, 2025

@swcurran swcurran marked this pull request as ready for review January 8, 2025 17:39
@swcurran swcurran merged commit 7188b32 into openwallet-foundation:main Jan 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants