-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-strict mode to AnomalibMetric #2508
Draft
djdameln
wants to merge
21
commits into
openvinotoolkit:main
Choose a base branch
from
djdameln:metric-add-strict-param
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_cubes_from_a_robotic_arm.ipynb: convert to Git LFS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds a non-strict mode to
AnomalibMetric
class, which reduces boilerplate code in applications where the batches passed toupdate
may or may not contain the required fields.strict
keyword argument toAnomalibMetric
class that defines the behaviour when the batch passed to update has missing fields.strict==True
(default), the behaviour will be the same as it was previously. The metric will raise an error if the field is not present in the passed instance, or if the value of the field is None.strict==False
, the metric will skip the update call of the internal metric, but not raise an error. Whencompute
is called, the metric will returnNone
if all calls to update were unsuccessful.OneClassPostProcessor
are an example how the non-strict mode can reduce boilerplate code.Other changes:
AnomalibMetric
.OneClassPostProcessor
MinMax
metric. This is no longer needed in v2.✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.