-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vv ensembl dev susmi #615
Open
Peter-J-Freeman
wants to merge
175
commits into
ensembl_update_2024
Choose a base branch
from
vv_ensembl_dev_susmi
base: ensembl_update_2024
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Vv ensembl dev susmi #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to vvta
commits that tackle what I saw for issue #387. It seems the reuested …
Remove bad return statement for issue https://github.com/openvar/vari…
Vv ensembl develop
Vv ensembl dev s working
Vv ensembl
Hide more recent version and not part of genome build warnings for irrelevant transcripts
We need slightly different bracket handling on predicted proteins, and different handling on */Ter= too. This allows us to fix the issue centrally rather than re-applying the edits in multiple places.
As yet unused, needed for object handling of protein variant mappings.
Expanded repeat formatting needs to happen before the final hgvs string to hgvs object conversion step, move it in preparation for switching this conversion to happening only once, inside initial format conversion.
Input formatting that depends on having a text quibble from user input needs to be completed before we parse into a hgvs object. Prepare for centralising input parsing by moving this kind of formatting before the intended hgvs string->hgvs object parsing point (at the end of the initial_format_conversions function).
Methyl syntax handling needs to happen before the first conversion into a hgvs object as the parser does not currently handle it.
Harden some initial input handling functions to cope with objects instead of strings, and add improved type aware posedit parsing.
Add required variables to handle methylation to the VVPosEdit, as well as a simple PosEdit to VVPosEdit function.
Jfw reparse reduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.