feat(tag): [tag] improve close icon interaction

[gweesin]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Nothing happened when hovering the close button.

Issue Number: #2555

What is the new behavior?

The close button should change the cursor to a pointer when hovered over, signaling that it's clickable.

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Style
  • Updated the tag component’s close icon to display a pointer cursor on hover, highlighting its interactivity.
  • Refined the close icon’s rendering for a more consistent and clean appearance.

[coderabbitai]

Walkthrough

This pull request modifies the tag component's styling. In the LESS stylesheet, a new CSS property (cursor: pointer;) is added to the close icon’s class to indicate interactivity. In the Vue component, extra whitespace in the icon-close class attribute is removed to standardize the markup. No changes were made to exported or public interfaces.

Changes

File	Change Summary
packages/theme/.../tag/index.less	Added cursor: pointer; to the .tag-prefix-cls__close class to indicate an interactive element.
packages/vue/.../tag/src/pc.vue	Removed extraneous whitespace in the icon-close class attribute in the render method.

Possibly related PRs

• fix(tabs): [tabs] Fixed the floating issue of the close button on the tab page and the style issue of the close button under the buttoncard. #2425: Adjusted the styling for a close button in the tabs component, which relates to the close icon style updates in this PR.

Suggested labels

enhancement

Suggested reviewers

• zzcr
• gimmyhehe

Poem

I'm a little rabbit hopping through the code,
With little tweaks and changes, a lighter load.
A pointer on the close, a space now gone,
Celebrating each update with a joyful song.
Hoppity-hop—code magic is in the air!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/vue/src/tag/src/pc.vue

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6cbb529 and 383a341.

📒 Files selected for processing (2)

• packages/theme/src/tag/index.less (1 hunks)
• packages/vue/src/tag/src/pc.vue (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• packages/vue/src/tag/src/pc.vue

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: PR E2E Test (pnpm test:e2e3)

🔇 Additional comments (2)

packages/theme/src/tag/index.less (2)

16-16: Tag Prefix Variable Initialization

The variable @tag-prefix-cls is defined using string interpolation with the tilde (~) syntax. This approach ensures that the evaluated string (incorporating @{css-prefix}) is treated correctly. Verify that this aligns with the overall project convention for prefix variables.

---

153-153: Improve Close Icon Interactivity

The addition of cursor: pointer; to the .@{tag-prefix-cls}__close class guarantees that users receive immediate visual feedback on hover, indicating clickable behavior. This change directly satisfies the PR objective regarding enhanced close icon interaction.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[petercat-assistant]

Walkthrough

This pull request introduces an enhancement to the close icon interaction within the tag component. The primary change is the addition of a cursor pointer style to the close icon, providing a visual indication that the icon is clickable when hovered over.

Changes

File	Summary
packages/theme/src/tag/index.less	Added cursor: pointer; to the close icon style to indicate clickability.
packages/vue/src/tag/src/pc.vue	Minor formatting change to the icon-close component usage.