Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add huicharts runtime and update docs #2981

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

zzcr
Copy link
Member

@zzcr zzcr commented Feb 27, 2025

添加huicharts的runtime打包逻辑

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Documentation
    • Revised installation guides to include additional package requirements and updated version notes.
    • Updated dependency references and stylesheet links to reflect the latest releases of Vue and associated libraries.
  • New Features
    • Integrated enhanced support for the Huicharts component, ensuring it is included in the build process.

Copy link

coderabbitai bot commented Feb 27, 2025

Walkthrough

The changes update the documentation and build configurations. The installation guides now require additional unplugin packages and support updated dependency versions, including a new import for @opentiny/vue-huicharts. In addition, the build process has been enhanced with a new task entry for the tiny-vue-huicharts library. These modifications adjust installation commands, dependency URLs, and build task configuration without altering existing public declarations.

Changes

File(s) Summary of Changes
examples/sites/demos/pc/webdoc/import-components.md
examples/sites/demos/pc/webdoc/installation.md
- Updated installation commands to include unplugin-auto-import and unplugin-vue-components.
- Added note requiring @opentiny/unplugin-tiny-vue version ≥ v1.0.0.
- Upgraded Vue and related packages (e.g., from Vue 3.4.27 to 3.5, and update from version 3.17 to 3.22).
- Added new import for @opentiny/vue-huicharts and updated stylesheet link.
internals/cli/src/commands/build/build-runtime.ts Added a new entry in getEntryTasks to include the tiny-vue-huicharts library, expanding the build runtime functionality.

Sequence Diagram(s)

sequenceDiagram
    participant CLI
    participant BuildRuntime
    participant HuichartsLib

    CLI->>BuildRuntime: Invoke build command
    BuildRuntime->>BuildRuntime: Execute getEntryTasks()
    BuildRuntime->>HuichartsLib: Process tiny-vue-huicharts task
Loading

Possibly related PRs

Suggested labels

enhancement

Poem

I hopped through lines of code so bright,
Tweaking docs and build tasks with delight,
New plugins and versions in a joyful parade,
Dependencies updated, no detail betrayed,
A bunny signs off—cheers to progress tonight! 🐰✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

internals/cli/src/commands/build/build-runtime.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-vue".

(The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-vue@latest --save-dev

The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the enhancement New feature or request (功能增强) label Feb 27, 2025
Copy link

Walkthrough

This pull request introduces the Huicharts runtime to the project and updates the documentation to reflect these changes. It includes modifications to the import components and installation guides, as well as updates to the build runtime configuration.

Changes

Files Summary
examples/sites/demos/pc/webdoc/import-components.md Updated to include additional plugin installation instructions and links to relevant resources.
examples/sites/demos/pc/webdoc/installation.md Updated import map and stylesheet links to reflect new version changes and added Huicharts runtime.
internals/cli/src/commands/build/build-runtime.ts Added new entry for Huicharts in the build runtime configuration.

Copy link

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
examples/sites/demos/pc/webdoc/installation.md (1)

97-98: Consider adding huicharts usage documentation

The import for huicharts has been added, but there's no documentation showing how to use this component. Consider adding a basic usage example either here or in a separate documentation file.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02e08e9 and 40936b7.

📒 Files selected for processing (3)
  • examples/sites/demos/pc/webdoc/import-components.md (2 hunks)
  • examples/sites/demos/pc/webdoc/installation.md (1 hunks)
  • internals/cli/src/commands/build/build-runtime.ts (1 hunks)
🔇 Additional comments (4)
internals/cli/src/commands/build/build-runtime.ts (1)

207-210: Addition of huicharts runtime support looks good

The new entry in the getEntryTasks function correctly adds support for the tiny-vue-huicharts library, with appropriate source path and library path configuration. This aligns with the PR objective of adding huicharts runtime support.

examples/sites/demos/pc/webdoc/import-components.md (2)

9-9: Important dependencies clarification added

Good addition clarifying that users need to install the official unplugin packages alongside @opentiny/unplugin-tiny-vue. This helps prevent installation issues.

Also applies to: 12-13


77-79: Complete reference links provided

The addition of the unplugin-tiny-vue link provides users with access to all necessary resources for auto-importing components.

examples/sites/demos/pc/webdoc/installation.md (1)

95-102: Updated dependency versions and added huicharts support

The installation documentation has been properly updated with:

  1. New Vue version (3.5)
  2. Added huicharts runtime import
  3. Updated all @opentiny package versions to 3.22
  4. Updated theme CSS link to match version 3.22

These changes align with the PR objective of adding huicharts support and updating documentation.

Also applies to: 107-107

@zzcr zzcr merged commit adf5c24 into dev Mar 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request (功能增强)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant