Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tree): [tree,popover] Component dark theme adaptation #2964

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Conversation

lcy0620
Copy link
Collaborator

@lcy0620 lcy0620 commented Feb 26, 2025

PR

feat(tree): [tree/popover] Component dark theme adaptation

PR Checklist

解决tree控件在暗黑主题下的高亮色,以及多处设置高亮色透明度色值会重叠加深问题
解决popover气泡卡片小三角图标色适配
Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Enhanced popover visuals by updating the arrow styling to match the overall theme background.
    • Refined the appearance of tree nodes by adjusting their background and hover effects, focusing on the left content area and icon interactions.
    • Updated the highlight color for tree nodes to support dynamic theming with a reference to a new variable.

@lcy0620 lcy0620 requested review from shenjunjian and zzcr February 26, 2025 03:02
Copy link

coderabbitai bot commented Feb 26, 2025

Walkthrough

This pull request updates the styling rules for the popover and tree components. A new CSS rule is added to style the .popper__arrow background using a CSS variable. Additionally, several tree node styles have been refined by removing outdated rules, updating selectors for left/right content areas, and replacing a static background color with a dynamic CSS variable.

Changes

File(s) Change Summary
packages/theme/src/popover/index.less Added a new CSS rule for .popper__arrow to set its background to var(--tv-Popover-bg-color).
packages/theme/src/tree/index.less,
packages/theme/src/tree/vars.less
Revised tree node styling by adjusting background rules, modifying hover effects, and updating the highlight color variable from a static color to var(--tv-color-bg-active.

Possibly related PRs

Suggested reviewers

  • zzcr

Poem

I'm a little rabbit hopping in delight,
Seeing popper arrows shine so bright.
Trees now wear a brand new hue,
Styling changes fresh as morning dew.
I nibble on code with a joyful bite!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d032033 and b664439.

📒 Files selected for processing (1)
  • packages/theme/src/tree/vars.less (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/theme/src/tree/vars.less
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the enhancement New feature or request (功能增强) label Feb 26, 2025
Copy link

Walkthrough

This PR adapts the tree and popover components for a dark theme. It addresses issues with highlight colors in the tree component under dark mode and adjusts the color of the popover arrow for better theme consistency.

Changes

Files Summary
packages/theme/src/popover/index.less Added background color for popover arrow to match dark theme.
packages/theme/src/tree/index.less Adjusted highlight and hover background colors, and added SVG icon color changes for dark theme adaptation.
packages/theme/src/tree/vars.less Updated tree node highlight background color variable for dark theme.

@lcy0620 lcy0620 changed the title feat(tree): [tree/popover] Component dark theme adaptation feat(tree): [tree] Component dark theme adaptation Feb 26, 2025
@lcy0620 lcy0620 changed the title feat(tree): [tree] Component dark theme adaptation feat(tree): [tree,popover] Component dark theme adaptation Feb 26, 2025
@zzcr zzcr merged commit 7de65d2 into dev Feb 26, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request (功能增强)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants