fix: optimize save code button marker position

[SonyLeo]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

保存代码按钮标记位置显示错误

Issue Number: N/A

What is the new behavior?

修复保存代码按钮标记位置

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• UI Enhancements
  • Updated toolbar button component with improved visual styling
  • Added optional dot indicator for buttons
  • Refined button layout and positioning
  • Adjusted styling and positioning of elements in the main component
  • Enhanced visual representation of save button's indicator

[coderabbitai]

Walkthrough

The pull request introduces modifications to the ToolbarBaseButton.vue, Main.vue, and Main.vue files, focusing on template structure and styling refinements. The changes involve wrapping the <tiny-button> within a <div class="svg-wrap"> and adding a conditional <span class="dot"> element based on the options?.showDots property. In Main.vue, the .icon-wrap and .red class styles were adjusted, while in Main.vue, the styling of the .dots element within the .save-btn class was modified for better visual representation.

Changes

File	Change Summary
packages/common/component/toolbar-built-in/ToolbarBaseButton.vue	- Replaced <span class="svg-wrap"> with <div class="svg-wrap"> - Added conditional rendering of <span class="dot"> - Renamed CSS class from .dots to .dot - Modified dot positioning (top: -3px, right: 2px)
packages/plugins/schema/src/Main.vue	- Added position: relative; to .icon-wrap - Altered .red class dimensions, border-radius, background color, and positioning
packages/plugins/script/src/Main.vue	- Reduced dimensions of .dots from 10px to 6px - Changed background color of .dots - Adjusted positioning of .dots (top: 9px, right: 34px)

Possibly related PRs

• feat(toolbars): use toolbar base component in toolbar plugins #798: The changes in ToolbarBaseButton.vue are directly related to the modifications made in the main PR, as both involve updates to the <tiny-button> component and the handling of the options prop, specifically regarding the visibility of dots.
• feat:sort out the status and API of the layout #736: This PR involves changes to the layout and organization of toolbar items, which may relate to the overall structure and functionality of the toolbar components, including ToolbarBaseButton.vue.
• feat: support checking all blocks in material add block panel #923: The introduction of the select-all functionality in PluginBlockList.vue and the new SelectAll component may relate to the enhancements in user interaction and visual representation in the toolbar components, including the ToolbarBaseButton.vue.

Suggested labels

refactor-main

Suggested reviewers

• hexqi
• chilingling

Poem

🐰 A button's dance, a subtle art,
Wrapped in SVG, a brand new start.
A dot appears with playful might,
Positioning tweaked, just feels right!
Code rabbit hops with pure delight! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 848a1c1 and fbacaff.

📒 Files selected for processing (2)

• packages/plugins/schema/src/Main.vue (2 hunks)
• packages/plugins/script/src/Main.vue (1 hunks)

🔇 Additional comments (3)

packages/plugins/script/src/Main.vue (1)

152-158: Styling changes successfully address marker positioning.

The reduced size and updated color align with the project's error color scheme, and the new top/right offsets will better place the indicator. This resolves the previously misaligned marker issue.

packages/plugins/schema/src/Main.vue (2)

197-197: Ensuring correct positioning context for .icon-wrap.

Marking the wrapper as position: relative is crucial for absolutely positioned children. This looks good but confirm no overlapping elements are unintentionally affected by this change.

---

207-215: Consistent styling for the indicator badge.

The updated .red class uses thematically consistent color variables and a circular shape, which is visually coherent with the changes in .dots. The negative offsets will place the badge at a more intuitive location.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/common/component/toolbar-built-in/ToolbarBaseButton.vue (1)

6-8: Enhance accessibility for the “save-title” span.
Including an aria-label or title attribute on the <span class="save-title"> might improve usability for screen readers, especially if this button’s function is critical.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da356e1 and 848a1c1.

📒 Files selected for processing (1)

• packages/common/component/toolbar-built-in/ToolbarBaseButton.vue (2 hunks)

🔇 Additional comments (3)

packages/common/component/toolbar-built-in/ToolbarBaseButton.vue (3)

2-3: Use optional chaining carefully to avoid potential runtime issues.
Your usage of options?.showDots short-circuits gracefully if options is undefined. This is good defensive coding. However, ensure that in older environments that do not support optional chaining, a suitable polyfill or transpilation step is used.

---

4-4: Validate button’s dynamic attributes.
The <tiny-button> component now resides inside a div.svg-wrap. Verify that the placement and any event bindings remain correct after introducing the wrapper.

---

48-56: Confirm the new dot styling.
The changes to .dot positioning (top: -3px; right: 2px;) correctly move it closer to the corner of the button. Verify that the dot remains visible under various container sizes and theming conditions.