-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename plugin name #771
Conversation
WalkthroughThe changes encompass a comprehensive renaming and restructuring of components, exports, and dependencies across various files. Key modifications include renaming Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant Toolbar
participant Plugin
User->>App: Initiate Code Generation
App->>Toolbar: Call GenerateCode
Toolbar->>Plugin: Use State Management
Plugin-->>Toolbar: Return State Info
Toolbar-->>App: Send Code
App-->>User: Display Generated Code
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
packages/plugins/state/assets/test.png
is excluded by!**/*.png
Files selected for processing (16)
- designer-demo/registry.js (2 hunks)
- jsconfig.json (4 hunks)
- packages/build/vite-config/src/vite-plugins/devAliasPlugin.js (2 hunks)
- packages/design-core/index.js (1 hunks)
- packages/design-core/package.json (2 hunks)
- packages/engine-cli/template/designer/registry.js (2 hunks)
- packages/plugins/state/package.json (2 hunks)
- packages/plugins/state/src/js/common.js (1 hunks)
- packages/plugins/state/src/js/constants.js (1 hunks)
- packages/plugins/state/vite.config.js (1 hunks)
- packages/register/src/constants.js (1 hunks)
- packages/toolbars/generate-code/meta.js (1 hunks)
- packages/toolbars/generate-code/package.json (3 hunks)
- packages/toolbars/generate-code/vite.config.js (1 hunks)
- packages/toolbars/lock/package.json (1 hunks)
- packages/toolbars/lock/vite.config.js (1 hunks)
Files skipped from review due to trivial changes (6)
- packages/plugins/state/package.json
- packages/plugins/state/src/js/common.js
- packages/plugins/state/src/js/constants.js
- packages/toolbars/generate-code/meta.js
- packages/toolbars/generate-code/package.json
- packages/toolbars/lock/vite.config.js
Additional comments not posted (23)
packages/toolbars/lock/package.json (1)
2-2
: LGTM!The package name change aligns with the PR objective to improve clarity and semantic relevance.
The code changes are approved.
packages/toolbars/generate-code/vite.config.js (2)
27-27
: LGTM!The library name change aligns with the PR objective to improve clarity and semantic relevance.
The code changes are approved.
32-32
: Verify the impact of removing Prettier from theexternal
array.The removal of the
^prettier.*
entry from theexternal
array may affect the build process. Ensure that this change does not introduce any issues.Run the following script to verify the impact:
packages/plugins/state/vite.config.js (1)
27-27
: LGTM!The library name change aligns with the PR objective to improve clarity and semantic relevance.
The code changes are approved.
designer-demo/registry.js (3)
24-24
: LGTM!The renaming of
GenerateVue
toGenerateCode
aligns with the broader functionality of generating code for various technology stacks.The code changes are approved.
28-28
: LGTM!The renaming of
Data
toState
aligns better with the intended functionality and improves semantic clarity.The code changes are approved.
75-75
: LGTM!The renaming of
GenerateVue
toGenerateCode
in thetoolbars
array aligns with the broader functionality of generating code for various technology stacks.The code changes are approved.
packages/engine-cli/template/designer/registry.js (3)
17-17
: LGTM!The renaming of
Checkinout
toLock
enhances understanding, especially since the associated icon has already been updated to represent a lock.The code changes are approved.
24-24
: LGTM!The renaming of
GenerateVue
toGenerateCode
aligns with the broader functionality of generating code for various technology stacks.The code changes are approved.
29-29
: LGTM!The renaming of
Data
toState
aligns better with the intended functionality and improves semantic clarity.The code changes are approved.
packages/register/src/constants.js (1)
29-29
: LGTM!The renaming of
GenerateVue
toGenerateCode
reflects a broader intent in the application's functionality regarding code generation.The code changes are approved.
packages/design-core/index.js (3)
8-8
: LGTM!The export statement correctly reflects the renaming of the plugin from
toolbar-checkinout
totoolbar-lock
.The code changes are approved.
14-14
: LGTM!The export statement correctly reflects the renaming of the plugin from
generate-vue
togenerate-code
.The code changes are approved.
19-19
: LGTM!The export statement correctly reflects the renaming of the plugin from
plugin-data
toplugin-state
.The code changes are approved.
jsconfig.json (3)
11-11
: LGTM!The path for
@opentiny/tiny-engine-plugin-state
is correctly updated.The code changes are approved.
27-27
: LGTM!The path for
@opentiny/tiny-engine-toolbar-lock
is correctly updated.The code changes are approved.
31-31
: LGTM!The path for
@opentiny/tiny-engine-toolbar-generate-code
is correctly updated.The code changes are approved.
packages/design-core/package.json (3)
55-55
: LGTM!The dependency for
@opentiny/tiny-engine-plugin-state
is correctly updated.The code changes are approved.
76-76
: LGTM!The dependency for
@opentiny/tiny-engine-toolbar-lock
is correctly updated.The code changes are approved.
80-80
: LGTM!The dependency for
@opentiny/tiny-engine-toolbar-generate-code
is correctly updated.The code changes are approved.
packages/build/vite-config/src/vite-plugins/devAliasPlugin.js (3)
21-21
: LGTM!The alias renaming from
@opentiny/tiny-engine-plugin-data
to@opentiny/tiny-engine-plugin-state
aligns with the PR objective to improve semantic clarity.The code changes are approved.
40-40
: LGTM!The alias renaming from
@opentiny/tiny-engine-toolbar-checkinout
to@opentiny/tiny-engine-toolbar-lock
aligns with the PR objective to enhance understanding.The code changes are approved.
45-45
: LGTM!The alias renaming from
@opentiny/tiny-engine-toolbar-generate-vue
to@opentiny/tiny-engine-toolbar-generate-code
aligns with the PR objective to reflect a broader capability.The code changes are approved.
规范插件包名称 工具栏generate-vue插件改名为 generate-code(不限定生成vue代码,传入不同的出码服务可以生成不同技术栈代码) 状态管理插件plugin-data改名为plugin-state,更符合语义 工具栏锁定插件toolbar-checkinout改名为 toolbar-lock,更易理解(当前图标早已切换为lock,而不是之前的checkin和checkout)
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
规范插件包名称
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Chores