-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复物料合成脚本,支持一个组件多个snippets #1159
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request updates the Changes
Sequence Diagram(s)sequenceDiagram
participant GC as generateComponents
participant B as Bundle Materials
participant CP as Component Processor
GC->>B: Initialize materials with a packages array
B-->>GC: Packages with 'TinyVue组件库' & 'element-plus组件库' added
loop For each component snippet
GC->>CP: Process snippet & determine group
CP-->>GC: Return grouped snippet data
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (3)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
1、新增物料流程中,拆分物料,增加物料,合并物料,组件无法正常加载了
看了下合并物料的逻辑里面没有加 pacakges 字段,导致组件未能正常加载到 TinyLowcodeComponent 中,进入区块加载逻辑,从而报错
2、对于组件 snippets 的处理,之前的逻辑是只会添加一个 snippet 到component 指定的分组,有一些场景比如 upload 组件,可能会配置 按钮上传、拖拽上传、图片上传等不同用例,便于使用,这种情况目前的脚本无法处理
What is the current behavior?
拆分物料,增加物料,合并物料,组件无法正常加载了
Issue Number: #1158
What is the new behavior?
1、增加了 packages 描述
2、增加逻辑,对组件 snippets 中的每一项,如果 snippet 中定义了 category 则放到该分组,如果未定义,则取 component 定义的 category 放到该分组,如果都没有定义则放到默认的 其他分组
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit