-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add @eslint/js deps declaring #1122
fix: add @eslint/js deps declaring #1122
Conversation
WalkthroughThe pull request adds a new dependency to the Changes
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/common/package.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: push-check
🔇 Additional comments (1)
packages/common/package.json (1)
36-36
:❓ Verification inconclusive
Verify the @eslint/js version.
Let's ensure we're using the latest secure version of @eslint/js.
🏁 Script executed:
#!/bin/bash # Check npm registry for latest version and any security advisories npm view @eslint/js versions --json | jq -r '.[-1]' npm audit @eslint/[email protected]Length of output: 439
Attention: Update @eslint/js Dependency & Validate Security Audit
The dependency in
packages/common/package.json
is currently set to"@eslint/js": "^8.57.1"
, but the registry shows version 10.0.0 as the latest release. This update may offer critical improvements and security fixes. Note that thenpm audit
command failed due to a missing lockfile. To properly audit, please:
- Update the dependency: Consider bumping the version to
"^10.0.0"
.- Generate a lockfile: Run
npm i --package-lock-only
(or your preferred lockfile generation command) to create a lockfile.- Run a security audit: Re-run
npm audit
after generating the lockfile to ensure there are no vulnerabilities.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
【问题描述】
pnpm install
pnpm build:plugin
【解决方案】
由于缺失依赖声明,加上依赖声明就好了
What is the current behavior?
Issue Number: #1126 #1112
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit