Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate structures during csv upload #879

Merged
merged 4 commits into from
Jun 29, 2021

Conversation

Rkareko
Copy link
Contributor

@Rkareko Rkareko commented Jun 28, 2021

Resolves #874

@Rkareko Rkareko requested a review from rkodev June 29, 2021 05:07
@Rkareko Rkareko assigned LZRS and Rkareko and unassigned LZRS Jun 29, 2021
@Rkareko Rkareko requested review from LZRS and qiarie June 29, 2021 05:35
@Rkareko Rkareko merged commit a5c2f18 into master Jun 29, 2021
@Rkareko Rkareko deleted the 874-validate-structures-during-csv-upload branch June 29, 2021 06:08
@madrinekariuki
Copy link

the structures validation during CSV upload is okay.
user: test99
plan name : MDA-Point 2021-07-02 MNK
plan ID: 4cc2904c-92c4-5e04-9f2f-9f6bdadf4665
Tested using a file with 3 kids 2 with a School ID not mapping the jurisdiction and 1 with correct school ID and location ID
-noted that only the kid with correct school ID and location ID was uploaded the other 2 were filtered out.
screenshots below.
uploaded file https://web.reveal-stage.smartregister.org/clients (ngwane Val 1)
Highlighted kid with correct school ID and location ID
image

only kid from that CSV showing on web and android.
image

Also noted that if an upload has correct schoolID and wrong location ID the validation Injects location ID from the provided school ID
tested using below upload.
https://web.reveal-stage.smartregister.org/clients(Ngwane val)
-all kids reflected on the ngwane practising school ID.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add structure and location validation for csv upload
3 participants