Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config Composition section to support custom search parameters #3695

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Merge remote-tracking branch 'origin/main' into 3532-custom-search-param

d354299
Select commit
Loading
Failed to load commit list.
Draft

Add config Composition section to support custom search parameters #3695

Merge remote-tracking branch 'origin/main' into 3532-custom-search-param
d354299
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 4, 2025 in 0s

38.4% (target 25.0%)

View this Pull Request on Codecov

38.4% (target 25.0%)

Details

Codecov Report

Attention: Patch coverage is 40.86022% with 55 lines in your changes missing coverage. Please review.

Project coverage is 38.4%. Comparing base (1542bb7) to head (d354299).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...tion/customsearch/SearchParametersConfigService.kt 0.0% 49 Missing ⚠️
...ne/util/extension/CompositionResourceExtensions.kt 75.0% 2 Missing and 3 partials ⚠️
...ircore/engine/util/extension/ReferenceExtension.kt 50.0% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3695     +/-   ##
=========================================
+ Coverage     37.9%   38.4%   +0.5%     
  Complexity    1157    1157             
=========================================
  Files          287     288      +1     
  Lines        15504   15063    -441     
  Branches      2730    2657     -73     
=========================================
- Hits          5884    5797     -87     
+ Misses        8776    8449    -327     
+ Partials       844     817     -27
Files with missing lines Coverage Δ
...smartregister/fhircore/engine/FhirEngineWrapper.kt 100.0% <100.0%> (ø)
...core/engine/configuration/ConfigurationRegistry.kt 61.2% <100.0%> (+0.1%) ⬆️
...hircore/engine/util/extension/ResourceExtension.kt 67.1% <ø> (-0.4%) ⬇️
...hircore/quest/ui/appsetting/AppSettingViewModel.kt 61.2% <ø> (-2.0%) ⬇️
...ircore/engine/util/extension/ReferenceExtension.kt 57.1% <50.0%> (-14.3%) ⬇️
...ne/util/extension/CompositionResourceExtensions.kt 75.0% <75.0%> (ø)
...tion/customsearch/SearchParametersConfigService.kt 0.0% <0.0%> (ø)

... and 33 files with indirect coverage changes

View more details on Codecov