Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knowledge Manager and Workflow Library Upgrades #3521

Merged
merged 26 commits into from
Mar 4, 2025

Conversation

ndegwamartin
Copy link
Contributor

@ndegwamartin ndegwamartin commented Sep 25, 2024

Closes #3639

This is a PR to track and migrate the latest updates of the FHIR SDK Knowledge and Workflow libraries.

Currently the features of Measure reporting and CQL evaluation are broken.

@ndegwamartin ndegwamartin added the DNM DO NOT MERGE label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 15.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 29.7%. Comparing base (1542bb7) to head (9b86cfe).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...register/fhircore/quest/ui/main/AppMainActivity.kt 0.0% 12 Missing ⚠️
...est/data/report/measure/MeasureReportRepository.kt 40.0% 3 Missing ⚠️
...core/engine/configuration/ConfigurationRegistry.kt 0.0% 1 Missing ⚠️
...st/ui/report/measure/worker/MeasureReportWorker.kt 0.0% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (15.0%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3521     +/-   ##
=========================================
- Coverage     37.9%   29.7%   -8.2%     
+ Complexity    1157     899    -258     
=========================================
  Files          287     287             
  Lines        15504   15504             
  Branches      2730    2732      +2     
=========================================
- Hits          5884    4619   -1265     
- Misses        8776   10320   +1544     
+ Partials       844     565    -279     
Flag Coverage Δ
engine 60.7% <50.0%> (-0.1%) ⬇️
geowidget 16.0% <ø> (ø)
quest 11.3% <11.1%> (-13.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../fhircore/engine/task/WorkflowCarePlanGenerator.kt 69.4% <100.0%> (-3.1%) ⬇️
...core/engine/configuration/ConfigurationRegistry.kt 61.1% <0.0%> (ø)
...st/ui/report/measure/worker/MeasureReportWorker.kt 0.0% <0.0%> (ø)
...est/data/report/measure/MeasureReportRepository.kt 63.2% <40.0%> (+2.9%) ⬆️
...register/fhircore/quest/ui/main/AppMainActivity.kt 10.8% <0.0%> (-1.8%) ⬇️

... and 31 files with indirect coverage changes

@ndegwamartin ndegwamartin force-pushed the migrate-workflow-libs branch 2 times, most recently from b53a928 to 6ed0940 Compare January 16, 2025 17:02
@ndegwamartin ndegwamartin force-pushed the migrate-workflow-libs branch from 36629e7 to 1708d93 Compare January 30, 2025 17:14
@ndegwamartin ndegwamartin removed the DNM DO NOT MERGE label Feb 12, 2025
@ndegwamartin ndegwamartin marked this pull request as ready for review February 12, 2025 15:41
@ndegwamartin ndegwamartin changed the title DNM | Knowledge Manager and Workflow Library Upgrades Knowledge Manager and Workflow Library Upgrades Feb 17, 2025
Copy link
Contributor

@f-odhiambo f-odhiambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is not building :(

@f-odhiambo f-odhiambo added DNM DO NOT MERGE Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions labels Feb 18, 2025
@ndegwamartin ndegwamartin removed the DNM DO NOT MERGE label Feb 20, 2025
- Fix failing unit tests ✅
@ndegwamartin ndegwamartin force-pushed the migrate-workflow-libs branch 2 times, most recently from 035cd6a to ce6c421 Compare February 27, 2025 06:06
- Workaround for failing FHIREngineProviderTestRule clean up
@ndegwamartin ndegwamartin force-pushed the migrate-workflow-libs branch from 97aad9e to c8724a2 Compare March 3, 2025 07:34
Copy link
Contributor

@f-odhiambo f-odhiambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. CQL Evaluation for Z Score works as expected
  2. In App reporting for indicators also works as expected

@f-odhiambo
Copy link
Contributor

f-odhiambo commented Mar 4, 2025

  1. CQL Evaluation for Z Score works as expected
  2. In-app reporting for indicators also works as expected
    NB. Ready for merge with one issue on Navigation drwaer not closing once you complete an evaluation

@ndegwamartin ndegwamartin merged commit bc73398 into main Mar 4, 2025
4 of 5 checks passed
@ndegwamartin ndegwamartin deleted the migrate-workflow-libs branch March 4, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work In Progress Describes an items that is not complete. Mostly used for scoping issues of discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in CQL and MeasureReporting - MIssing version artifact,
2 participants