Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define sync strategy #1569

Merged
merged 3 commits into from
Aug 24, 2022
Merged

Define sync strategy #1569

merged 3 commits into from
Aug 24, 2022

Conversation

FikriMilano
Copy link
Member

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #1512
Ideally, this is to be merged after #890

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #1569 (e2e87a2) into main (2748ebc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1569      +/-   ##
============================================
+ Coverage     52.20%   52.23%   +0.03%     
- Complexity      657      659       +2     
============================================
  Files           191      192       +1     
  Lines          6793     6798       +5     
  Branches       1216     1216              
============================================
+ Hits           3546     3551       +5     
+ Misses         2645     2644       -1     
- Partials        602      603       +1     
Flag Coverage Δ
engine 65.52% <100.00%> (+0.04%) ⬆️
quest 33.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...smartregister/fhircore/engine/sync/SyncStrategy.kt 100.00% <100.00%> (ø)
...egister/fhircore/quest/ui/main/AppMainViewModel.kt 49.48% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FikriMilano FikriMilano merged commit ed887e9 into main Aug 24, 2022
@FikriMilano FikriMilano deleted the 1512-define-sync-strategy branch August 24, 2022 03:46
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Add syncStrategy to app config JSON

* Define syncStrategy

* Add test for syncStrategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sync Optimization] Define the sync strategy on the Application Config
2 participants