fix: add guard for setTotalCount #5180

opensquare-network · Dec 12, 2024 · 1e55a95 · 1e55a95
1 parent 1f40986
commit 1e55a95
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/next-common/components/assets/assetsList.js b/packages/next-common/components/assets/assetsList.js
@@ -51,17 +51,17 @@ export const colTransfer = {
 
 export default function AssetsList({ address }) {
   const { loading, assets } = useQueryAddressAssets(address);
-  const [, setTotalCount] = useTotalCounts();
+  const [totalCounts, setTotalCount] = useTotalCounts();
   const colTotal = useColTotal(address);
   const colTransferrable = useColTransferrable(address);
 
   useEffect(() => {
-    if (loading) {
+    if (loading || assets?.length === totalCounts.assets) {
       return;
     }
 
     setTotalCount("assets", assets?.length || 0);
-  }, [assets, setTotalCount, loading]);
+  }, [assets, setTotalCount, loading, totalCounts.assets]);
 
   const columnsDef = [
     colToken,

diff --git a/packages/next-common/components/profile/assets/assetsList.js b/packages/next-common/components/profile/assets/assetsList.js
@@ -13,19 +13,19 @@ import { useTotalCounts } from "next-common/components/assets/context/assetHubTa
 
 export default function ProfileAssetsList({ address }) {
   const { loading, assets } = useQueryAddressAssets(address);
-  const [, setTotalCount] = useTotalCounts();
+  const [totalCounts, setTotalCount] = useTotalCounts();
   const colTotal = useColTotal(address);
   const colTransferrable = useColTransferrable(address);
 
   const columnsDef = [colToken, colId, colName, colTotal, colTransferrable];
 
   useEffect(() => {
-    if (loading) {
+    if (loading || assets?.length === totalCounts.assets) {
       return;
     }
 
     setTotalCount("assets", assets?.length || 0);
-  }, [assets, setTotalCount, loading]);
+  }, [assets, setTotalCount, loading, totalCounts.assets]);
 
   return (
     <ScrollerX>