Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build rhcos extensions image nightly #30351

Merged
merged 1 commit into from
Jul 11, 2022
Merged

build rhcos extensions image nightly #30351

merged 1 commit into from
Jul 11, 2022

Conversation

cheesesashimi
Copy link
Member

This creates nightly builds for the RHCOS extensions image defined under https://github.com/openshift/os/tree/master/extensions. When built, the image will be pullable from registry.ci.openshift.org/rhcos-devel/rhel-coreos-extensions:latest. This PR is meant to supercede #30236.

@openshift-ci openshift-ci bot requested review from ashcrow and lucab July 11, 2022 18:48
@cheesesashimi cheesesashimi force-pushed the zzlotnik/build-rhcos-extensions-container branch from 41986ca to 73bcf45 Compare July 11, 2022 18:50
@cheesesashimi cheesesashimi marked this pull request as draft July 11, 2022 18:53
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2022
@cheesesashimi cheesesashimi force-pushed the zzlotnik/build-rhcos-extensions-container branch from 73bcf45 to b06f256 Compare July 11, 2022 18:56
cheesesashimi
cheesesashimi commented Jul 11, 2022
View reviewed changes
ci-operator/config/openshift/os/openshift-os-master__periodic.yaml
cron: '@daily'
steps:
test:
- as: validate-rhcos-base-image
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewer: I combined these under a single test so we have a single job that builds both images. Otherwise, the image builds could run at different times and may get out of sync.

@cheesesashimi cheesesashimi force-pushed the zzlotnik/build-rhcos-extensions-container branch from b06f256 to 88932af Compare July 11, 2022 19:02
@cheesesashimi cheesesashimi marked this pull request as ready for review July 11, 2022 19:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2022
@openshift-ci openshift-ci bot requested review from jmarrero and mike-nguyen July 11, 2022 19:12
jmarrero
jmarrero approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@jmarrero jmarrero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, naming is good with me too. I would wait to merge on @cgwalters or @travier on naming because of future rhcos/scos naming just in case.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2022
@jmarrero
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, cheesesashimi, jmarrero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 3bdeac8 into openshift:master Jul 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2022

@cheesesashimi: Updated the following 4 configmaps:

  • job-config-master-postsubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-os-master-postsubmits.yaml using file ci-operator/jobs/openshift/os/openshift-os-master-postsubmits.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-os-master-presubmits.yaml using file ci-operator/jobs/openshift/os/openshift-os-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-os-master__periodic.yaml using file ci-operator/config/openshift/os/openshift-os-master__periodic.yaml
  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-os-master-periodics.yaml using file ci-operator/jobs/openshift/os/openshift-os-master-periodics.yaml

In response to this:

This creates nightly builds for the RHCOS extensions image defined under https://github.com/openshift/os/tree/master/extensions. When built, the image will be pullable from registry.ci.openshift.org/rhcos-devel/rhel-coreos-extensions:latest. This PR is meant to supercede #30236.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2022

@cheesesashimi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-os-master-periodic-validate-extensions-image 41986ca4b07bb5b20dfc1a3a41efce44efd94727 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

travier
travier reviewed Jul 12, 2022
View reviewed changes
ci-operator/config/openshift/os/openshift-os-master__periodic.yaml
machine-os-oci-content:
as:
- registry.ci.openshift.org/rhcos-devel/rhel-coreos:latest
to: rhcos-extensions-8.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I would prefer that we don't introduce versions everywhere that we would have to update / remove after and use generic names until we've figure out how we will support RHCOS 9.0. I'll make a PR.

travier added a commit to travier/release that referenced this pull request Jul 12, 2022
@travier
ci-operator/openshift/os: Remove 8.6 references
ed90428 
Remove RHEL 8.6 references and use unversioned names for images until we
have figured out how we will support RHCOS 9.

See:
- openshift#30351
- openshift/os#882
@travier travier mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier left review comments

@cgwalters cgwalters cgwalters approved these changes

@jmarrero jmarrero jmarrero approved these changes

@ashcrow ashcrow Awaiting requested review from ashcrow

@lucab lucab Awaiting requested review from lucab

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

Assignees

@cgwalters cgwalters

@jmarrero jmarrero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cheesesashimi @jmarrero @cgwalters @travier