Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCIDOCS-260: Clarification on configuring RAID with RHOCP #86823

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

johnwilkins
Copy link
Contributor

@johnwilkins johnwilkins commented Jan 8, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2025

@johnwilkins: This pull request references HCIDOCS-260 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Clarifies that software RAID is not support on installation drives. It is supported for storage drives.

Fixes: HCIDOCS-260

See https://issues.redhat.com/browse/HCIDOCS-260 for additional details.

Preview URL: http://jowilkin.com:8080/HCIDOCS-260/welcome/index.html

For release(s): 4.14-4.18
QE Review:

  • QE has approved this change.

Signed-off-by: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2025

@johnwilkins: This pull request references HCIDOCS-260 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Clarifies that software RAID is not support on installation drives. It is supported for storage drives.

Fixes: HCIDOCS-260

See https://issues.redhat.com/browse/HCIDOCS-260 for additional details.

Preview URL: https://86823--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/install_config/installing-customizing.html and https://86823--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/ipi/ipi-install-post-installation-configuration.html#bmo-about-the-baremetalhost-resource_ipi-install-post-installation-configuration

For release(s): 4.14-4.18
QE Review:

  • QE has approved this change.

Signed-off-by: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jan 8, 2025

@johnwilkins: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Chin2691
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Jan 11, 2025

@Chin2691: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 12, 2025

@johnwilkins: This pull request references HCIDOCS-260 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Clarifies that software RAID is not support on installation drives. It is supported for storage drives.

Fixes: HCIDOCS-260

See https://issues.redhat.com/browse/HCIDOCS-260 for additional details.

Preview URL: https://86823--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/install_config/installing-customizing.html and https://86823--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/ipi/ipi-install-post-installation-configuration.html#bmo-about-the-baremetalhost-resource_ipi-install-post-installation-configuration

For release(s): 4.14-4.18
QE Review:

  • QE has approved this change.

Signed-off-by: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@johnwilkins
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 12, 2025
@abhatt-rh
Copy link
Contributor

/label peer-review-in-progress

Copy link
Contributor

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 13, 2025
@johnwilkins
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 13, 2025
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 13, 2025
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 13, 2025
@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 13, 2025
@jeana-redhat jeana-redhat merged commit bbb3de2 into openshift:main Jan 13, 2025
2 checks passed
@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.18

@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.17

@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.16

@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.15

@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #86957

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #86958

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #86959

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jeana-redhat: #86823 failed to apply on top of branch "enterprise-4.15":

Applying: HCIDOCS-260: Clarifies that the installation drive cannot use software RAID..
Using index info to reconstruct a base tree...
M	modules/bmo-about-the-baremetalhost-resource.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/bmo-about-the-baremetalhost-resource.adoc
CONFLICT (content): Merge conflict in modules/bmo-about-the-baremetalhost-resource.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 HCIDOCS-260: Clarifies that the installation drive cannot use software RAID..

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@jeana-redhat: #86823 failed to apply on top of branch "enterprise-4.14":

Applying: HCIDOCS-260: Clarifies that the installation drive cannot use software RAID..
Using index info to reconstruct a base tree...
M	modules/bmo-about-the-baremetalhost-resource.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/bmo-about-the-baremetalhost-resource.adoc
CONFLICT (content): Merge conflict in modules/bmo-about-the-baremetalhost-resource.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 HCIDOCS-260: Clarifies that the installation drive cannot use software RAID..

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jeana-redhat
Copy link
Contributor

@johnwilkins I'll merge the ones that are cooperating, but looks like you have some manual picks to open here as well alas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants