Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TELCODOCS-1862 - Adding release note for PTP events REST API v2 #81486

Conversation

aireilly
Copy link
Contributor

@aireilly aireilly commented Sep 9, 2024

Adding release note for PTP events REST API v2

Version(s):
enterprise-4.17

Issue:
https://issues.redhat.com/browse/TELCODOCS-1862

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@aireilly aireilly force-pushed the TELCODOCS-1862-O-RAN-API-release-note branch from defd609 to adaff4b Compare September 9, 2024 13:59
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2024
@aireilly aireilly force-pushed the TELCODOCS-1862-O-RAN-API-release-note branch from adaff4b to e7773a6 Compare September 9, 2024 14:10
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 9, 2024

🤖 Wed Sep 11 10:27:10 - Prow CI generated the docs preview:

https://81486--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-17-release-notes.html

@aireilly
Copy link
Contributor Author

aireilly commented Sep 9, 2024

@Bonnie-Block PTAL

@Bonnie-Block
Copy link

/lgtm

Copy link

openshift-ci bot commented Sep 9, 2024

@Bonnie-Block: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aireilly aireilly force-pushed the TELCODOCS-1862-O-RAN-API-release-note branch from e7773a6 to f8b3063 Compare September 10, 2024 14:05
@aireilly
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 10, 2024
@maxwelldb maxwelldb added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 10, 2024
@maxwelldb maxwelldb self-requested a review September 10, 2024 14:57
@aireilly aireilly force-pushed the TELCODOCS-1862-O-RAN-API-release-note branch from f8b3063 to 059ef2d Compare September 10, 2024 15:00
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Offered a few suggestions.

release_notes/ocp-4-17-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-17-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-17-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-17-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-17-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-17-release-notes.adoc Outdated Show resolved Hide resolved
@maxwelldb maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 10, 2024
@maxwelldb maxwelldb added this to the Planned for 4.17 GA milestone Sep 10, 2024
@aireilly aireilly force-pushed the TELCODOCS-1862-O-RAN-API-release-note branch from 059ef2d to 53d9449 Compare September 10, 2024 17:05
@aireilly aireilly force-pushed the TELCODOCS-1862-O-RAN-API-release-note branch from 53d9449 to 9e0a861 Compare September 11, 2024 10:19
@aireilly aireilly merged commit 4943d35 into openshift:enterprise-4.17 Sep 11, 2024
2 checks passed
Copy link

openshift-ci bot commented Sep 11, 2024

@aireilly: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR peer-review-needed Signifies that the peer review team needs to review this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants