Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-21751: update ip_whitelist entry #66299

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Oct 16, 2023

@jldohmann jldohmann added this to the Continuous Release milestone Oct 16, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 16, 2023
@openshift-ci-robot
Copy link

@jldohmann: This pull request references Jira Issue OCPBUGS-21751, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s): 4.11+

Issue: https://issues.redhat.com/browse/OCPBUGS-21751

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 16, 2023

🤖 Updated build preview is available at:
https://66299--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/28631

@jldohmann
Copy link
Contributor Author

@melvinjoseph86 could you PTAL for QE ack? thank you!

@jldohmann jldohmann added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 16, 2023
@mburke5678 mburke5678 added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 16, 2023
@mburke5678
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
modules/nw-route-specific-annotations.adoc Outdated Show resolved Hide resolved
modules/nw-route-specific-annotations.adoc Outdated Show resolved Hide resolved
Comment on lines 70 to 78
[.small]
--
1. If the number of IP addresses and CIDR ranges in an allowlist exceeds 64, they are written into a separate file that is then referenced from `haproxy.config`.
+
[NOTE]
====
To ensure that the addresses are written to the allowlist, check that the full list of CIDR ranges are listed in the Ingress Controller configuration file. The etcd object size limit restricts how large a route annotation can be. Because of this, it creates a threshold for the maximum number of IP addresses and CIDR ranges that you can include in an allowlist.
====
--

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my suggestion is to add this portion just after line 44 to have a continuation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The technical limitations of how tables are currently rendering makes content unreadable inside a cell, but I can take a look at a later time whenever the issue is resolved

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

New changes are detected. LGTM label has been removed.

@jldohmann jldohmann merged commit 83c3edc into openshift:main Oct 18, 2023
@openshift-ci-robot
Copy link

@jldohmann: Jira Issue OCPBUGS-21751 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Version(s): 4.11+

Issue: https://issues.redhat.com/browse/OCPBUGS-21751

Link to docs preview: https://66299--docspreview.netlify.app/openshift-enterprise/latest/networking/routes/route-configuration#nw-route-specific-annotations_route-configuration

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.14

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.13

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.12

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@jldohmann: new pull request created: #66482

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jldohmann: new pull request created: #66483

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jldohmann: new pull request created: #66484

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jldohmann: new pull request created: #66485

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann jldohmann deleted the OCPBUGS-21751 branch October 18, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants