-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-21751: update ip_whitelist entry #66299
Conversation
@jldohmann: This pull request references Jira Issue OCPBUGS-21751, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/28631 |
@melvinjoseph86 could you PTAL for QE ack? thank you! |
/lgtm |
[.small] | ||
-- | ||
1. If the number of IP addresses and CIDR ranges in an allowlist exceeds 64, they are written into a separate file that is then referenced from `haproxy.config`. | ||
+ | ||
[NOTE] | ||
==== | ||
To ensure that the addresses are written to the allowlist, check that the full list of CIDR ranges are listed in the Ingress Controller configuration file. The etcd object size limit restricts how large a route annotation can be. Because of this, it creates a threshold for the maximum number of IP addresses and CIDR ranges that you can include in an allowlist. | ||
==== | ||
-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my suggestion is to add this portion just after line 44 to have a continuation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The technical limitations of how tables are currently rendering makes content unreadable inside a cell, but I can take a look at a later time whenever the issue is resolved
7af7bee
to
6807024
Compare
New changes are detected. LGTM label has been removed. |
@jldohmann: Jira Issue OCPBUGS-21751 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.14 |
/cherrypick enterprise-4.13 |
/cherrypick enterprise-4.12 |
/cherrypick enterprise-4.11 |
@jldohmann: new pull request created: #66482 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jldohmann: new pull request created: #66483 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jldohmann: new pull request created: #66484 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jldohmann: new pull request created: #66485 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): 4.11+
Issue: https://issues.redhat.com/browse/OCPBUGS-21751
Link to docs preview: https://66299--docspreview.netlify.app/openshift-enterprise/latest/networking/routes/route-configuration#nw-route-specific-annotations_route-configuration
QE review:
Additional information: