Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TELCODOCS-1004, TELCODOCS-1207 - CNF-6527/CNF-7078 PTP Operator HW plugin + GNSS monitoring/events #62621

Merged
merged 1 commit into from
Dec 13, 2023
Merged

TELCODOCS-1004, TELCODOCS-1207 - CNF-6527/CNF-7078 PTP Operator HW plugin + GNSS monitoring/events #62621

merged 1 commit into from
Dec 13, 2023

Conversation

aireilly
Copy link
Contributor

@aireilly aireilly commented Jul 20, 2023 •
edited
Loading

@aireilly aireilly force-pushed the telcodocs-1004-ptp-hw-plugin branch from 5449c30 to 883e8c2 Compare July 20, 2023 12:10
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2023
@aireilly aireilly force-pushed the telcodocs-1004-ptp-hw-plugin branch from 883e8c2 to a923be5 Compare July 20, 2023 12:16
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 20, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://62621--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/36661

@aireilly aireilly force-pushed the telcodocs-1004-ptp-hw-plugin branch 3 times, most recently from cb598b6 to 284eafc Compare July 20, 2023 14:51
@aireilly aireilly changed the title TELCODOCS-1004 - CNF-6527 PTP Operator HW Specific Functionality Plugin [TELCODOCS-1004, TELCODOCS-1207] - CNF-6527/CNF-7078 PTP Operator HW plugin + GNSS monitoring/events Jul 24, 2023
@aireilly aireilly force-pushed the telcodocs-1004-ptp-hw-plugin branch 4 times, most recently from 8a3ce05 to 5288880 Compare July 27, 2023 10:30
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 27, 2023
@aireilly aireilly force-pushed the telcodocs-1004-ptp-hw-plugin branch 6 times, most recently from 143bb94 to 3fa13b7 Compare July 31, 2023 16:58
@aireilly aireilly changed the title [TELCODOCS-1004, TELCODOCS-1207] - CNF-6527/CNF-7078 PTP Operator HW plugin + GNSS monitoring/events WIP [TELCODOCS-1004, TELCODOCS-1207] - CNF-6527/CNF-7078 PTP Operator HW plugin + GNSS monitoring/events Jul 31, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2023
@aireilly aireilly force-pushed the telcodocs-1004-ptp-hw-plugin branch 6 times, most recently from 899c6ec to fe556c7 Compare August 1, 2023 16:52
@aireilly aireilly force-pushed the telcodocs-1004-ptp-hw-plugin branch 2 times, most recently from 87fceb7 to 06bb6c1 Compare August 8, 2023 14:51
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@Bonnie-Block
Copy link

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 6, 2023

@Bonnie-Block: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhatt-rh
abhatt-rh reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @aireilly!
I left a couple of comments. Also, I see that the version specified is 4.14, but I'm thinking it's 4.14+. Can you confirm?

modules/cnf-about-collecting-ptp-data.adoc Outdated Show resolved Hide resolved
modules/cnf-fast-event-notifications-api-refererence.adoc Outdated Show resolved Hide resolved
modules/cnf-monitoring-fast-events-metrics.adoc Outdated Show resolved Hide resolved
modules/cnf-troubleshooting-common-ptp-operator-issues.adoc Outdated Show resolved Hide resolved
modules/cnf-troubleshooting-common-ptp-operator-issues.adoc Outdated Show resolved Hide resolved
modules/nw-ptp-operator-metrics-reference.adoc Outdated Show resolved Hide resolved
modules/nw-ptp-operator-metrics-reference.adoc Outdated Show resolved Hide resolved
snippets/ptp-clock-holdover-note.adoc Outdated Show resolved Hide resolved
snippets/ptp-clock-holdover-note.adoc Outdated Show resolved Hide resolved
modules/ptp-overview-of-gnss-grandmaster-clock.adoc Show resolved Hide resolved
@abhatt-rh abhatt-rh added this to the Continuous Release milestone Dec 8, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 8, 2023

New changes are detected. LGTM label has been removed.

@aireilly aireilly force-pushed the telcodocs-1004-ptp-hw-plugin branch 5 times, most recently from 54742f4 to e4b0018 Compare December 8, 2023 11:47
@abhatt-rh abhatt-rh added branch/enterprise-4.15 peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 8, 2023
@aireilly aireilly force-pushed the telcodocs-1004-ptp-hw-plugin branch 3 times, most recently from 13ff421 to 7a8b099 Compare December 13, 2023 11:00
@aireilly
E810 hardware plugin doc updates
cd53070 
WPC T-GM + GNSS updates

General PTP docs reorg and clean up

Updates based on Aneesh's review comments

removing gnss-state-change from api/ocloudNotifications/v1/<resource_address>/CurrentState

Adding metric details

Adding new PTP image

Adding final PTP 4.14 image

Aneesh's comments

jack's comments

Adjust TOC

Peer review comments
@aireilly aireilly force-pushed the telcodocs-1004-ptp-hw-plugin branch from 7a8b099 to cd53070 Compare December 13, 2023 11:01
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 13, 2023

@aireilly: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aireilly aireilly merged commit 6c06d77 into openshift:main Dec 13, 2023
3 checks passed
@aireilly
Copy link
Contributor Author

/cherrypick enterprise-4.14

@aireilly
Copy link
Contributor Author

/cherrypick enterprise-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 13, 2023
Merged
@openshift-cherrypick-robot
Copy link

@aireilly: new pull request created: #69306

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 13, 2023
Merged
@openshift-cherrypick-robot
Copy link

@aireilly: new pull request created: #69307

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhatt-rh abhatt-rh abhatt-rh left review comments

@aneeshkp aneeshkp aneeshkp requested changes

@jzding jzding jzding approved these changes

Assignees

@aneeshkp aneeshkp

@jzding jzding

Labels
branch/enterprise-4.14 branch/enterprise-4.15 peer-review-done Signifies that the peer review team has reviewed this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@aireilly @ocpdocs-previewbot @kalexand-rh @abhatt-rh @Bonnie-Block @openshift-cherrypick-robot @aneeshkp @jzding @openshift-merge-robot