-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding a build-changed-pages.py script #48582
[WIP] Adding a build-changed-pages.py script #48582
Conversation
36587be
to
6e3baaf
Compare
@kalexand-rh hi! Can you please review this PR? Thanks! |
fcf0a4b
to
3004c7d
Compare
After a bit of testing, it looks like the current approach in this script might only be useful for commits that change a few pages. This is because AsciiBinder only seems to allow you to specify the I can't see a way to specify more than one page in a single AsciiBinder build run. For example:
I haven't yet been able to find any detailed AsciiBinder documentation or help items on the option. I am continuing to review if there is a way to build more than one page in a single AsciiBinder build run. If we can't find a way to build multiple selected pages in a single run, we could potentially explore the following if condition:
|
This relates to #48653. |
3004c7d
to
8855e95
Compare
I created this RFE issue in AsciiBinder in relation to this. |
pages_to_build = list(dict.fromkeys(pages_to_build)) | ||
# Run 'asciibinder build' for each page that is changed in the HEAD commit, including any unchanged assemblies that include changed modules: | ||
print(f"Attempting to build the pages changed in the HEAD commit:") | ||
for i in pages_to_build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could these processes be threaded in parallel? https://stackoverflow.com/a/14533902/7010427 This would solve your bottle neck. Right now, you are running builds sequentially.
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR is a work in progress. Do not merge.
This applies to
main
,enterprise-4.11
,enterprise-4.10
,enterprise-4.9
,enterprise-4.8
,enterprise-4.7
andenterprise-4.6
.This PR adds a
./build-changed-pages.py
script to the top level directory in the openshift-docs repo. You can run the script to build AsciiBinder previews only for openshift-docs pages that are changed in the latest commit in the branch.The development is primarily intended for potential use with the Travis checks for the openshift-docs repo. This script can also be run manually in a local clone feature branch.
See the header of the script for details on how to run it.