-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-43552: maxUnavailable value is not honored when disabling OCL #4799
base: master
Are you sure you want to change the base?
Conversation
@dkhater-redhat: This pull request references Jira Issue OCPBUGS-43552, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkhater-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dkhater-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What I did
Fixed a bug in the node controller where the maxUnavailable setting was not honored when ocl was disabled. The issue was due to the getAllCandidateMachines function not properly checking for nodes that were mid-update. I added a condition to skip nodes that are currently being updated, ensuring that we do not exceed the maxUnavailable limit.
How to verify it
Enable OCL in the worker pool
Remove the MOSC resource to disable OCL
view node status to make sure nodes do not update simultaneously
Description for the changelog
Fixed an issue where maxUnavailable was not honored when ocl is disabled, ensuring node updates respect the maximum unavailable node count.