Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-43552: maxUnavailable value is not honored when disabling OCL #4799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkhater-redhat
Copy link
Contributor

What I did
Fixed a bug in the node controller where the maxUnavailable setting was not honored when ocl was disabled. The issue was due to the getAllCandidateMachines function not properly checking for nodes that were mid-update. I added a condition to skip nodes that are currently being updated, ensuring that we do not exceed the maxUnavailable limit.

How to verify it

Enable OCL in the worker pool
Remove the MOSC resource to disable OCL
view node status to make sure nodes do not update simultaneously
Description for the changelog

Fixed an issue where maxUnavailable was not honored when ocl is disabled, ensuring node updates respect the maximum unavailable node count.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 22, 2025
@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-43552, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What I did
Fixed a bug in the node controller where the maxUnavailable setting was not honored when ocl was disabled. The issue was due to the getAllCandidateMachines function not properly checking for nodes that were mid-update. I added a condition to skip nodes that are currently being updated, ensuring that we do not exceed the maxUnavailable limit.

How to verify it

Enable OCL in the worker pool
Remove the MOSC resource to disable OCL
view node status to make sure nodes do not update simultaneously
Description for the changelog

Fixed an issue where maxUnavailable was not honored when ocl is disabled, ensuring node updates respect the maximum unavailable node count.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

@dkhater-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op a272b80 link true /test e2e-gcp-op
ci/prow/e2e-azure-ovn-upgrade-out-of-change a272b80 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-hypershift a272b80 link true /test e2e-hypershift
ci/prow/unit a272b80 link true /test unit
ci/prow/e2e-gcp-op-ocl a272b80 link false /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants