Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - KubeAPIServerVirtualIP #5555

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP - KubeAPIServerVirtualIP #5555

wants to merge 1 commit into from

Conversation

EmilienM
Copy link
Member

@EmilienM EmilienM commented Feb 4, 2025

/hold

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 4, 2025
@EmilienM EmilienM marked this pull request as draft February 4, 2025 16:42
@openshift-ci openshift-ci bot requested review from hasueki and sjenning February 4, 2025 16:43
@openshift-ci openshift-ci bot added area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Feb 4, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the area/documentation Indicates the PR includes changes for documentation label Feb 4, 2025
EmilienM
EmilienM commented Feb 4, 2025
View reviewed changes
api/hypershift/v1beta1/openstack.go
//
// +kubebuilder:validation:XValidation:rule="isIP(self)",message="kubeAPIServerVirtualIP must be a valid IPv4 or IPv6 address"
// +optional
KubeAPIServerVirtualIP string `json:"kubeAPIServerVirtualIP,omitempty"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brain dump idea: create a type that has an IP and a hostname as well.
The hostname would be used to update HostedCluster.Status.ControlPlaneEndpoint (if it's possible) or at least generate a kubeconfig using that hostname (a hostname is prettier than an IP).
And I think we would need to create the Service annotation to give the hostname, so the certificate would be valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasueki hasueki Awaiting requested review from hasueki

@sjenning sjenning Awaiting requested review from sjenning

Assignees
No one assigned
Labels
area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EmilienM