Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOJIRA: Create token Secret for dev cluster explicitly #5523

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mgencur
Copy link

@mgencur mgencur commented Jan 31, 2025

Needs to be created manually because:
Prior to OpenShift Container Platform 4.16, a long-lived service account API token secret was also generated for each service account that was created. Starting with OpenShift Container Platform 4.16, this service account API token secret is no longer created.

Related Slack discussion

What this PR does / why we need it:
With the new version of OpenShift, the Secret/Token is not created automatically.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Needs to be created manually because:
Prior to OpenShift Container Platform 4.16, a long-lived service account
API token secret was also generated for each service account that was
created. Starting with OpenShift Container Platform 4.16, this service
account API token secret is no longer created.
@csrwng
Copy link
Contributor

csrwng commented Jan 31, 2025

/area ci

Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

@csrwng: The label(s) area/ci cannot be applied, because the repository doesn't have them.

In response to this:

/area ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@csrwng
Copy link
Contributor

csrwng commented Jan 31, 2025

/approve

Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2025
@devguyio
Copy link
Contributor

/area ci-tooling

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Jan 31, 2025
@devguyio
Copy link
Contributor

/retitle "NOJIRA: Create token Secret for dev cluster explicitly"

@openshift-ci openshift-ci bot changed the title Create token Secret for dev cluster explicitly "NOJIRA: Create token Secret for dev cluster explicitly" Jan 31, 2025
@devguyio
Copy link
Contributor

/retitle NOJIRA: Create token Secret for dev cluster explicitly

@openshift-ci openshift-ci bot changed the title "NOJIRA: Create token Secret for dev cluster explicitly" NOJIRA: Create token Secret for dev cluster explicitly Jan 31, 2025
@mgencur
Copy link
Author

mgencur commented Feb 3, 2025

/test okd-scos-e2e-aws-ovn

The error error doesn't seem to be related to my changes.

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

@mgencur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants