Add support for Equinix Metal #283
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ metadata: | |
| name: cloudcredentials.operator.openshift.io | ||
| annotations: | ||
| include.release.openshift.io/self-managed-high-availability: "true" | ||
| include.release.openshift.io/single-node-developer: "true" | ||
|
There was a problem hiding this comment. Updating this through |
||
| spec: | ||
| scope: Cluster | ||
| group: operator.openshift.io | ||
|
|
@@ -44,12 +45,15 @@ spec: | |
| type: object | ||
| properties: | ||
| credentialsMode: | ||
| description: 'CredentialsMode allows informing CCO that it should | ||
| not attempt to dynamically determine the root cloud credentials | ||
| capabilities, and it should just run in the specified mode. It also | ||
| allows putting the operator into "manual" mode if desired. Leaving | ||
| the field in default mode runs CCO so that the cluster''s cloud | ||
| credentials will be dynamically probed for capabilities (on supported | ||
| clouds/platforms). Supported modes: AWS/Azure/GCP: "" (Default), | ||
| "Mint", "Passthrough", "Manual" Others: Do not set value as other | ||
| platforms only support running in "Passthrough"' | ||
| type: string | ||
| enum: | ||
| - "" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,10 +5,10 @@ go 1.13 | |
| require ( | ||
| cloud.google.com/go v0.56.0 | ||
| github.com/Azure/azure-sdk-for-go v31.1.0+incompatible | ||
| github.com/Azure/go-autorest/autorest v0.11.1 | ||
| github.com/Azure/go-autorest/autorest/adal v0.9.5 | ||
| github.com/Azure/go-autorest/autorest/azure/auth v0.4.2 | ||
| github.com/Azure/go-autorest/autorest/date v0.3.0 | ||
| github.com/Azure/go-autorest/autorest/to v0.3.0 | ||
| github.com/Azure/go-autorest/autorest/validation v0.2.0 // indirect | ||
| github.com/aws/aws-sdk-go v1.37.14 | ||
|
|
@@ -19,12 +19,11 @@ require ( | |
| github.com/gogo/protobuf v1.3.2 // indirect | ||
| github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b | ||
| github.com/golang/mock v1.4.3 | ||
| github.com/google/uuid v1.1.2 | ||
| github.com/googleapis/gnostic v0.5.1 // indirect | ||
| github.com/imdario/mergo v0.3.10 // indirect | ||
| github.com/onsi/ginkgo v1.14.0 // indirect | ||
| github.com/openshift/api v0.0.0-20210225162315-bae60f47eed7 | ||
| github.com/openshift/build-machinery-go v0.0.0-20200917070002-f171684f77ab | ||
| github.com/openshift/library-go v0.0.0-20200911100307-610c6e9e90b8 | ||
| github.com/pkg/errors v0.9.1 | ||
|
|
@@ -45,10 +44,10 @@ require ( | |
| google.golang.org/grpc v1.28.0 | ||
| gopkg.in/square/go-jose.v2 v2.5.1 | ||
| gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b | ||
| k8s.io/api v0.20.0 | ||
| k8s.io/apimachinery v0.20.0 | ||
| k8s.io/client-go v0.20.0 | ||
| k8s.io/code-generator v0.20.0 | ||
|
Comment on lines
+47
to
+50
There was a problem hiding this comment. This was required when I added the replace for I believe the other updates came in transitively through the replace and these updates There was a problem hiding this comment. yeah, seems like you got caught in the middle of some changes |
||
| k8s.io/utils v0.0.0-20201110183641-67b214c5f920 | ||
| sigs.k8s.io/controller-runtime v0.6.2 | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ metadata: | |
| name: cloudcredentials.operator.openshift.io | ||
| annotations: | ||
| include.release.openshift.io/self-managed-high-availability: "true" | ||
| include.release.openshift.io/single-node-developer: "true" | ||
|
There was a problem hiding this comment. Updating this through There was a problem hiding this comment. here's a little background on this annotation, https://github.com/openshift/enhancements/blob/master/enhancements/single-node-developer-cluster-profile.md |
||
| spec: | ||
| scope: Cluster | ||
| group: operator.openshift.io | ||
|
|
@@ -44,12 +45,15 @@ spec: | |
| type: object | ||
| properties: | ||
| credentialsMode: | ||
| description: 'CredentialsMode allows informing CCO that it should | ||
| not attempt to dynamically determine the root cloud credentials | ||
| capabilities, and it should just run in the specified mode. It also | ||
| allows putting the operator into "manual" mode if desired. Leaving | ||
| the field in default mode runs CCO so that the cluster''s cloud | ||
| credentials will be dynamically probed for capabilities (on supported | ||
| clouds/platforms). Supported modes: AWS/Azure/GCP: "" (Default), | ||
| "Mint", "Passthrough", "Manual" Others: Do not set value as other | ||
| platforms only support running in "Passthrough"' | ||
| type: string | ||
| enum: | ||
| - "" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,6 +59,7 @@ func addKnownTypes(scheme *runtime.Scheme) error { | |
| &GCPProviderStatus{}, &GCPProviderSpec{}, | ||
| &VSphereProviderStatus{}, &VSphereProviderSpec{}, | ||
| &KubevirtProviderStatus{}, &KubevirtProviderSpec{}, | ||
| &EquinixMetalProviderStatus{}, &EquinixMetalProviderSpec{}, | ||
| ) | ||
|
|
||
| return nil | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| Copyright 2020 The OpenShift Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1 | ||
|
|
||
| import ( | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| ) | ||
|
|
||
| // TODO: these types should eventually be broken out, along with the actuator, | ||
| // to a separate repo. | ||
|
|
||
| // EquinixMetalProviderSpec contains the required information to create RBAC role | ||
| // bindings for EquinixMetal. | ||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | ||
| type EquinixMetalProviderSpec struct { | ||
| metav1.TypeMeta `json:",inline"` | ||
| } | ||
|
|
||
| // EquinixMetalProviderStatus contains the status of the credentials request in EquinixMetal. | ||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | ||
| type EquinixMetalProviderStatus struct { | ||
| metav1.TypeMeta `json:",inline"` | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In an ideal world, this Secret should not even exist on a cluster as the individual components that need to make cloud API calls would receive their credentials via Secrets directly. This allows for a future where we can introduce fine-grained creds/permissions if/when the platform/cloud allows it.