Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

namespace: edit CleanObjects #915

Merged
merged 1 commit into from
Feb 4, 2025
Merged

namespace: edit CleanObjects #915

merged 1 commit into from
Feb 4, 2025

Conversation

ajaggapa
Copy link
Contributor

@ajaggapa ajaggapa commented Feb 4, 2025 •
edited
Loading

CleanObjects is not working when there is only 1 pod/resource in terminating state

@ajaggapa ajaggapa requested a review from kononovn as a code owner February 4, 2025 08:27
klaskosk
klaskosk approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@klaskosk klaskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@klaskosk klaskosk merged commit 4e2e8cf into openshift-kni:main Feb 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaskosk klaskosk klaskosk approved these changes

@sebrandon1 sebrandon1 sebrandon1 approved these changes

@kononovn kononovn Awaiting requested review from kononovn kononovn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajaggapa @sebrandon1 @klaskosk