Fix the pod name for comDetails #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endpointslices/endpointslices.go
Outdated
| @@ -200,6 +201,24 @@ func getContainerName(portNum int, pods []corev1.Pod) (string, error) { | |||
| return res, nil | |||
| } | |||
|
|
|||
| func getPodName(pod *corev1.Pod) string { | |||
| var res string | |||
| name := pod.OwnerReferences[0].Name | |||
There was a problem hiding this comment.
Not all pods have OwnerReferences
There was a problem hiding this comment.
would you agree that we will return empty string in that case?
There was a problem hiding this comment.
after a second look, it looks like the case where pods don't have OwnerReferences, they append the node name, so I'll do the same treatment like with Kind=Node
There was a problem hiding this comment.
I added this use case plus more others, verifying it against unit tests. please re-review :)
liornoy
force-pushed
the
fix-com-detail-name
branch
2 times, most recently
from
32d5cc4 to
3f3af57
Compare
Modifies the function for creating comDetails, so the pod name will be more accurate. We fetch the name from the OwnerReference, and modify the name if needed. Added unit tests for the function. Signed-off-by: Lior Noy <[email protected]>
liornoy
force-pushed
the
fix-com-detail-name
branch
from
3f3af57 to
7b29f60
Compare
|
Fixed in #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the function for creating comDetails,
so the pod name will be more accurate.