-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the flaky test testExtractDatePartWithTimeType() #3225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224 and
noCharger
as code owners
December 30, 2024 03:26
YANG-DB
previously approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
changed the title
Fix the failure test testExtractDatePartWithTimeType()
Fix the flaky test testExtractDatePartWithTimeType()
Dec 30, 2024
Signed-off-by: Lantao Jin <[email protected]>
gentle ping @YANG-DB @dai-chen @penghuo @noCharger @ykmr1224 . Currently, CI failures in almost PRs relates to this issue. |
Seems there is an open issue #2477 and provided a temporary fix for similar another tests which are not including this one. |
penghuo
approved these changes
Jan 8, 2025
YANG-DB
approved these changes
Jan 8, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
* Fix the failure test testExtractDatePartWithTimeType() Signed-off-by: Lantao Jin <[email protected]> * skip test week with time type in Jan and Dec Signed-off-by: Lantao Jin <[email protected]> * add doc Signed-off-by: Lantao Jin <[email protected]> * fix incorrect format Signed-off-by: Lantao Jin <[email protected]> --------- Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit 0e4acd3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin
pushed a commit
that referenced
this pull request
Jan 9, 2025
* Fix the failure test testExtractDatePartWithTimeType() * skip test week with time type in Jan and Dec * add doc * fix incorrect format --------- (cherry picked from commit 0e4acd3) Signed-off-by: Lantao Jin <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flaky test:
Caused by function extract(WEEK FROM ...) actually returns the number of the ISO 8601 week-of-week-based-year:
So the current expected number
53
in the test day 2024-12-30 is incorrect.The fixing is skipping the testing in December and January.
Related Issues
Resolves #3224
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.