-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow metadata fields in PPL query #2789
Merged
LantaoJin
merged 1 commit into
opensearch-project:main
from
LantaoJin:pr/bugfix_issue_2788
Jan 10, 2025
Merged
Allow metadata fields in PPL query #2789
LantaoJin
merged 1 commit into
opensearch-project:main
from
LantaoJin:pr/bugfix_issue_2788
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
ykmr1224
as code owners
June 28, 2024 12:28
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
force-pushed
the
pr/bugfix_issue_2788
branch
from
July 9, 2024 06:46
446622c
to
9c8ba3d
Compare
dai-chen
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
This PR is stalled because it has been open for 30 days with no activity. |
YANG-DB
approved these changes
Jan 1, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit e415325) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 tasks
noCharger
pushed a commit
that referenced
this pull request
Jan 24, 2025
* Allow metadata fields in PPL query (#2789) Signed-off-by: Lantao Jin <[email protected]> (cherry picked from commit e415325) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix the doctest Signed-off-by: Lantao Jin <[email protected]> --------- Signed-off-by: Lantao Jin <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Lantao Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpenSearch reserved fields (_id, _index, _sort, _score, _max_score) are not allowed to be used in PPL clauses because the field format starting with underscore _ is not allowed.
#1456 had fixed the same problem for SQL query, but the issue still existed in PPL.
Issues Resolved
Resolves #2788
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.