Upgrade gradle to 8.5 #2470
Closed
Upgrade gradle to 8.5 #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2470 +/- ##
=========================================
Coverage 95.41% 95.41%
Complexity 5000 5000
=========================================
Files 479 479
Lines 13950 13950
Branches 937 937
=========================================
Hits 13310 13310
Misses 618 618
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Might also be related to query workbench/dashboards observability autocuts |
derek-ho
requested review from
pjfitzgibbons,
ps48,
kavithacm,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
|
Merged PR with upgrade to 8.4. So closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Autocuts seem to be failing with the following error: Could not open settings generic class cache for settings file '/tmp/tmpe5afgno0/sql/settings.gradle' (/home/ci-runner/.gradle/caches/7.6.1/scripts/9ay5uc1kgv3krvoxgzbw9z61y).
Indicating incompatibility between gradle and jdk 21 - which is now being used to build opensearch 3. https://github.com/opensearch-project/opensearch-build/blob/main/manifests/3.0.0/opensearch-3.0.0.yml#L9. Confirmed this to be the case by checking compatibility page: https://docs.gradle.org/current/userguide/compatibility.html stating that Java 21 is compatible with 8.4 and 8.5. Bumping to 8.5 to be consistent with core/security plugin.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.