[Backport 2.x] Async query get result bug fix #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add IT to reproduce the bug first Signed-off-by: Chen Dai <[email protected]> * Modify IT as temporary reproduce commit Signed-off-by: Chen Dai <[email protected]> * Fix issue by preferred option and modify IT Signed-off-by: Chen Dai <[email protected]> * Refactor IT with fluent assertion Signed-off-by: Chen Dai <[email protected]> * Add IT for batch query handler Signed-off-by: Chen Dai <[email protected]> * Add IT for streaming query handler Signed-off-by: Chen Dai <[email protected]> * Add more IT for normal case Signed-off-by: Chen Dai <[email protected]> * Add IT for drop index Signed-off-by: Chen Dai <[email protected]> * Consider drop statement running if result doc unavailable Signed-off-by: Chen Dai <[email protected]> * Fix broken UT Signed-off-by: Chen Dai <[email protected]> * Address PR comments Signed-off-by: Chen Dai <[email protected]> * Address PR comments Signed-off-by: Chen Dai <[email protected]> --------- Signed-off-by: Chen Dai <[email protected]> (cherry picked from commit 60058ce) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #2447 +/- ##
=========================================
Coverage 95.45% 95.45%
- Complexity 5027 5029 +2
=========================================
Files 479 479
Lines 14077 14084 +7
Branches 935 936 +1
=========================================
+ Hits 13437 13444 +7
Misses 618 618
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dai-chen
approved these changes
Dec 1, 2023
vamsimanohar
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 60058ce from #2443.