[WIP][Prometheus] PrometheusClient use Labels API for "describe" resultset #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Fitzgibbons <[email protected]>
| @@ -83,6 +83,17 @@ public Map<String, List<MetricMetadata>> getAllMetrics() throws IOException { | |||
| return new ObjectMapper().readValue(jsonObject.getJSONObject("data").toString(), typeRef); | |||
| } | |||
|
|
|||
| @Override | |||
| public List<String> getAllSeriesLabels() throws IOException { | |||
There was a problem hiding this comment.
Can you add use case to the PR description, what are we trying to achieve?
There was a problem hiding this comment.
I'm only looking for your review on throughput and generic functionality.
There are some hardcoded values that I will produce dynamically in a fast-follow commit on this PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #2435 +/- ##
============================================
- Coverage 96.61% 94.83% -1.79%
- Complexity 4751 5128 +377
============================================
Files 438 482 +44
Lines 12742 14615 +1873
Branches 869 995 +126
============================================
+ Hits 12311 13860 +1549
- Misses 422 734 +312
- Partials 9 21 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Is this still in progress? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify PrometheusClient to use Prometheus Labels API for PPL "describe" results, instead of Prometheus "metadata" API.
Prometheus series will only produce a "metadata" record if the Prometheus server actively scrapes the configured metrics source server.
In the case of backfilling via
promtool tsdb create-blocks-from, this scraping event does not occur. In the case of development or test environment, this scraping event may never occur.All series are exposed by the Prometheus Labels API, via endpoint
/api/v1/label/__name__/values. Prometheus naming conventions can be used to determine the "unit" and "type" of each series. This is the expected internal behaviour of the Prometheus service itself.Use case :
Script-generated backfill files are created, with content similar to :
Upon ingestion of this backfill via the cli
promtool tsdb create-blocks-from /tmp/test_usage_backfill.txt, the series is visible in the Promethus Web UI (http://localhost:9090) via the "metrics browser".Yet the series is not visible in the Metadata API (
/api/v1/metdata).This result is irrespective of any configuration in
prometheus.ymlfor scraping, relabeling, or other configuration feautres.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.