Ensure Github workflow runs on docker image used by Production Distribution Build #3868
Conversation
reta
force-pushed
the
issue-3494
branch
12 times, most recently
from
d9489f8 to
0313e6e
Compare
| @@ -13,6 +13,11 @@ env: | |||
| CI_ENVIRONMENT: normal | |||
|
|
|||
| jobs: | |||
| Get-CI-Image-Tag: | |||
| uses: opensearch-project/opensearch-build/.github/workflows/get-ci-image-tag.yml@main | |||
There was a problem hiding this comment.
Lets use a published task not a direct repo reference
There was a problem hiding this comment.
Hm... may you share the example? (PS: this step is replicated to all repos)
There was a problem hiding this comment.
I don't like tightly coupling these repositories together; security depends on opensearch-build, opensearch build depends on security - this is a formula to get into a broken state and have to start bypassing CI.
There was a problem hiding this comment.
For example, here is a GitHub action that allows for multi-platform file download [1] it shouldn't be part of the security project even though it was originally written to support this project.
I have trouble adopting this level of coupling when we still have problems doing normal builds after version bumps [2]
There was a problem hiding this comment.
I am still unsure what you are suggesting, my apologies. If this is not the way we should share the workflows, no objections to change it, but to what model?
There was a problem hiding this comment.
We should publish the workflows as github actions e.g. opensearch-project/opensearch-ci-image-by-tag@v1?
There was a problem hiding this comment.
Oh I see, thanks @peternied , @peterzhuamazon fyi ^^
The only change should be an usage of our (OpenSearch) image for Linux runner (instead of ubuntu-latest), the only price to be paid is for pulling the image . |
…bution Build Signed-off-by: Andriy Redko <[email protected]>
reta
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
RyanL1997,
stephen-crawford and
willyborankin
as code owners
|
@peternied opening it up for review, if you prefer to have Githib Action (instead of referencing the workflow directly), I have no objection - please feel to close this one (and preferably open an issue for |
|
Thanks @reta I'm created an issue for OpenSearch-build to publish a GitHub action [1] that should be how we adopt that job. After this has been created, we'll be in a position to adopt this change in this repo. |
Description
Ensure Github workflow runs on docker image used by Production Distribution Build
Issues Resolved
Closes #3494
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Tested as Github Action worflows
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.