Bump ejs and express versions to address CVEs #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
RyanL1997 and
stephen-crawford
as code owners
stephen-crawford
approved these changes
Jun 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1988 +/- ##
=======================================
Coverage 70.61% 70.61%
=======================================
Files 97 97
Lines 2600 2600
Branches 380 380
=======================================
Hits 1836 1836
Misses 668 668
Partials 96 96 ☔ View full report in Codecov by Sentry. |
DarshitChanpura
approved these changes
Jun 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 9abc57d)
derek-ho
added a commit
that referenced
this pull request
Jun 8, 2024
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 9abc57d) Co-authored-by: Derek Ho <[email protected]>
|
@derek-ho Since the security-dashboards-plugin does not have a direct dependency on either of these, shouldn't the update be done in OSD core? Similar to: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3542/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps ejs to 3.1.10 to address: CVE-2024-33883
Bumps express to 4.19.2 to address CVE-2024-29041
Category
Maintenance
Why these changes are required?
Address CVEs
What is the old behavior before changes and new behavior after changes?
No diff
Issues Resolved
Don't have one right now
Testing
None
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.