-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register Datasource Picker in the top nav menu for Get Started Tab #1818
Register Datasource Picker in the top nav menu for Get Started Tab #1818
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/supporting-multiple-datasources #1818 +/- ##
===========================================================================
+ Coverage 67.52% 67.65% +0.13%
===========================================================================
Files 94 95 +1
Lines 2414 2427 +13
Branches 327 330 +3
===========================================================================
+ Hits 1630 1642 +12
- Misses 706 707 +1
Partials 78 78 ☔ View full report in Codecov by Sentry. |
08668bc
to
6a27220
Compare
2a0ba26
to
95158fa
Compare
929dd88
to
942b2f7
Compare
Signed-off-by: Darshit Chanpura <[email protected]>
37de405
to
e33907e
Compare
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks close to me from the first pass. left some comments. Thanks @derek-ho for taking this on!
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
.github/workflows/cypress-test-multidatasources-disabled-e2e.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
@@ -745,21 +747,20 @@ export function defineRoutes(router: IRouter) { | |||
router.delete( | |||
{ | |||
path: `${API_PREFIX}/configuration/cache`, | |||
validate: false, | |||
validate: { | |||
body: schema.object({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should dataSourceId(s) always be passed in as query params?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, since we control all the places this is called (only in the get started tab) I think it's fine to require it. This isn't using query params though it's only an internal implementation. However I think this is a two way door decision and once more routes are modified we can easily refactor it to a cleaner way if we find one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that makes sense can you merge? Thanks!
4ba9fcf
into
opensearch-project:feature/supporting-multiple-datasources
Description
Registers the new DataSource picker component from core in the top nav menu for the "Get Started" Tab.
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
New feature
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Old behavior is no selector, new behavior is shown in this video:
Screen.Recording.2024-03-20.at.10.53.21.AM.mov
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Fix: #1796, Fix: #1816 Fix: #1795
Testing
Manual testing, unit tests added, e2e cypress test added
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.