-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Run Security dashboards plugin from binary #1734
Conversation
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 9b88d92)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1734 +/- ##
=======================================
Coverage 66.76% 66.76%
=======================================
Files 93 93
Lines 2353 2353
Branches 311 311
=======================================
Hits 1571 1571
Misses 705 705
Partials 77 77 ☔ View full report in Codecov by Sentry. |
@derek-ho Could you look into the failures?
|
Should be added on line 63 to get the version to switch to. Can somebody with write access help me to commit that into this PR? |
Signed-off-by: Derek Ho <[email protected]>
@derek-ho Can you also 'forward' port the change you added to main in another PR so these files are consistant? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @derek-ho. As Peter suggested, the change to fetch osd-version
should be forward ported to main to be consistent.
Done in: #1739 |
Backport 9b88d92 from #1726