Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Run Security dashboards plugin from binary #1734

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9b88d92 from #1726

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 9b88d92)
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98b6556) 66.76% compared to head (06ec63f) 66.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #1734   +/-   ##
=======================================
  Coverage   66.76%   66.76%           
=======================================
  Files          93       93           
  Lines        2353     2353           
  Branches      311      311           
=======================================
  Hits         1571     1571           
  Misses        705      705           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied
Copy link
Member

@derek-ho Could you look into the failures?

/home/runner/work/_temp/f3bb7ace-d8[17](https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/7547628965/job/20547990269?pr=1734#step:14:18)-4afe-8ac0-a40528df3e48.sh: line 1: build/opensearch-dashboards-2.12.0-SNAPSHOT-linux-x64/bin/opensearch-dashboards-plugin: No such file or directory

@derek-ho
Copy link
Collaborator

- id: osd-version
        run: |
          echo "::set-output name=osd-version::$(jq -r '.opensearchDashboards.version | split(".") | .[:2] | join(".")' package.json)"
          echo "::set-output name=osd-x-version::$(jq -r '.opensearchDashboards.version | split(".") | .[0]' package.json).x"
        shell: bash

Should be added on line 63 to get the version to switch to. Can somebody with write access help me to commit that into this PR?

@peternied
Copy link
Member

@derek-ho Can you also 'forward' port the change you added to main in another PR so these files are consistant?

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @derek-ho. As Peter suggested, the change to fetch osd-version should be forward ported to main to be consistent.

@derek-ho
Copy link
Collaborator

Done in: #1739

@DarshitChanpura DarshitChanpura merged commit 46eee99 into 2.x Jan 17, 2024
24 checks passed
@github-actions github-actions bot deleted the backport/backport-1726-to-2.x branch January 17, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants