-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.3] Increment version to 1.3.14.0 #1659
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.3 #1659 +/- ##
=======================================
Coverage 72.48% 72.48%
=======================================
Files 88 88
Lines 1926 1926
Branches 246 246
=======================================
Hits 1396 1396
Misses 474 474
Partials 56 56 ☔ View full report in Codecov by Sentry. |
@opensearch-project/engineering-effectiveness Can someone create a min distro of core for 1.3.14? https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.14/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-security-1.3.14.0.zip and https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.14/latest/windows/x64/zip/builds/opensearch/plugins/opensearch-security-1.3.14.0.zip are missing. |
Hey! Looks like 1.13.14 manifest only contains OpenSearch for now https://github.com/opensearch-project/opensearch-build/blob/main/manifests/1.3.14/opensearch-1.3.14.yml |
Oh I see, the main and 2.x branches are publishing snapshots to maven and the 1.3 branch is not publishing the snapshots. I will update the 1.3 branch to pull SNAPSHOTs from maven to build with. |
I don't believe that would work as publishing zip snapshots was started from 2.x version? @prudhvigodithi please correct if I am wrong. |
I'm going to raise a PR to add security to the manifest in the build repo. |
@gaiksaya I raised a PR on the build repo to add security to the manifest for 1.3.14: opensearch-project/opensearch-build#4226 Thank you for the help! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused. Shall we first bump the version here in order to build security-1.3.14
artifact? @gaiksaya
NVM, just realize this is the security dashboards plugin. :D |
Opened up a PR in OSD core to increment the version to 1.3.14. This PR is blocked until OSD Core is incremented. |
Signed-off-by: Derek Ho <[email protected]>
Description
Increment version to 1.3.14.0
Category
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.