[Refactor-1160] Different Values Pointing to Basic Auth, Need to Unify #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhas Kurapati <[email protected]>
Signed-off-by: Prabhas Kurapati <[email protected]>
prabhask5
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1619 +/- ##
=======================================
Coverage 66.29% 66.29%
=======================================
Files 93 93
Lines 2344 2344
Branches 317 317
=======================================
Hits 1554 1554
Misses 720 720
Partials 70 70
|
Signed-off-by: Prabhas Kurapati <[email protected]>
|
@cwperks @DarshitChanpura @scrawfor99 This PR is ready for review I'm pretty sure, I'm not sure how to fix the code coverage warning if that is something I can fix, would like some guidance on that part. Ty! |
|
@prabhask5 Can you merge in the latest from main into this branch? There are fixes for the integ tests in the main branch. |
cwperks
reviewed
Oct 27, 2023
There was a problem hiding this comment.
Hey @prabhask5 , I left a few comments. This PR looks good to me, but I'm not sure about changing instances of empty string to AuthType.BASIC.
Signed-off-by: Prabhas Kurapati <[email protected]>
Signed-off-by: Prabhas Kurapati <[email protected]>
cwperks
reviewed
Oct 30, 2023
Signed-off-by: Prabhas Kurapati <[email protected]>
|
@cwperks @DarshitChanpura Following up on the review request, tysm! |
stephen-crawford
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Looks good to me--way to bust these out @prabhask5 thanks for all your great work.
cwperks
approved these changes
Nov 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
#1619) * finished ticket Signed-off-by: Prabhas Kurapati <[email protected]> * fixed invalid auth type error Signed-off-by: Prabhas Kurapati <[email protected]> * fixed unit tests Signed-off-by: Prabhas Kurapati <[email protected]> * made requested changes Signed-off-by: Prabhas Kurapati <[email protected]> * updated saml to AuthType.SAML + fixed basicauth test Signed-off-by: Prabhas Kurapati <[email protected]> --------- Signed-off-by: Prabhas Kurapati <[email protected]> (cherry picked from commit 2131598)
|
Thank you @prabhask5 ! Sorry I just got home from a conference yesterday and had limited time to review PRs. This looks good to me 🚢 |
leanneeliatra
pushed a commit
to leanneeliatra/security-dashboards-plugin-fork
that referenced
this pull request
Nov 17, 2023
opensearch-project#1619) * finished ticket Signed-off-by: Prabhas Kurapati <[email protected]> * fixed invalid auth type error Signed-off-by: Prabhas Kurapati <[email protected]> * fixed unit tests Signed-off-by: Prabhas Kurapati <[email protected]> * made requested changes Signed-off-by: Prabhas Kurapati <[email protected]> * updated saml to AuthType.SAML + fixed basicauth test Signed-off-by: Prabhas Kurapati <[email protected]> --------- Signed-off-by: Prabhas Kurapati <[email protected]> Signed-off-by: [email protected] <[email protected]>
DarshitChanpura
added a commit
that referenced
this pull request
Nov 17, 2023
#1619) (#1649) --------- Signed-off-by: Prabhas Kurapati <[email protected]> (cherry picked from commit 2131598) Co-authored-by: Prabhas Kurapati <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unified previous different basic auth formats ('basicauth', '', AuthType.BASIC) to one basic auth format (AuthType.BASIC), by changing all instances of 'basicauth' and '' in relation to auth types to AuthType.BASIC.
Category
Refactoring
Why these changes are required?
The different basic auth formats were confusing since they appeared to represent different auth types but they all pointed to the same auth type. Refactoring clears this confusion up.
What is the old behavior before changes and new behavior after changes?
Old behavior: 'basicauth', '' in relation to authType, AuthType.BASIC exist, new behavior: only AuthType.BASIC exists
Issues Resolved
#1160
Testing
Manually tested to make sure nothing broke, updated related auth type tests to include new AuthType.BASIC format.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.