Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push out some event page edits #2450

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Push out some event page edits #2450

merged 5 commits into from
Nov 27, 2023

Conversation

krisfreedain
Copy link
Member

Description

Fix next Community Meeting time zone
Fix more events metadata

Issues Resolved

#2449
#2418

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

smortex and others added 5 commits November 8, 2023 08:15
The event does not include the location information (city, country, TZ)
so the event page lacks a lot of information.

While here, adjust the event logic so that events which started and are
not finished at the time of rendering appear both in the future events
(because it is what is displayed on the event page and the event is
still in progress) and the past events.

Also adjust the event template with actual sample data in comments to
make it more obvious for people using it what they need to adjust.

Signed-off-by: Romain Tartière <[email protected]>
Check that non-online events have location information, a tz set, and
that the event date use the right time zone.

Signed-off-by: Romain Tartière <[email protected]>
Copy link
Member

@nateynateynate nateynateynate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@nateynateynate nateynateynate merged commit 7c49f75 into prod Nov 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants