Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xoriant as new partner #2257

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

Ram-Kumaar-ML
Copy link
Contributor

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@Ram-Kumaar-ML
Copy link
Contributor Author

@krisfreedain - Created a new PR and figured out the DCO issue . For some reason, I'm unable to do a local build of the site and have updated the xoriant.md file with the error fixed (hopefully). Please kindly check.

@krisfreedain
Copy link
Member

thanks @Ram-Kumaar-ML DCO works!

I'm getting an odd error
"project-website/_partners/xoriant.md: (): found character that cannot start any token while scanning for the next token at line 47 column 1"
so I'll investigate that and see what we need to fix.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the addrss format will resolve the error.

# In the template rendering multiple_office_locations takes precedent,
# and if both are used only the multiple_office_locations data will be rendered
# in the template omitting the main_office_location data.
main_office_location:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ram-Kumaar-ML The format for the address requires a multiline string format with new lines preserved using the | character. Here's a SO discussion that gives some straight forward detail about the variants. https://stackoverflow.com/questions/3790454/how-do-i-break-a-string-in-yaml-over-multiple-lines
Also, refer to _partners/_sample.md, or real world examples in many other *.md within the _partners collection.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astephanus - I'm still seeing that odd error when I pull it down locally - can you give it another look?

"_partners/xoriant.md: (): found character that cannot start any token while scanning for the next token at line 47 column 1"

@pajuric
Copy link

pajuric commented Oct 20, 2023

@Ram-Kumaar-ML - checking in on this and seeing if there is anything I can do to help get your company updated.

@pajuric
Copy link

pajuric commented Mar 29, 2024

@Ram-Kumaar-ML - Just checking in to see if you're able to help resolve this. Looks like there's still an error.

Copy link
Member

@nateynateynate nateynateynate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made an executive decision and fixed the frontmatter for Xoriant to take out the tabs. Not sure why Jekyll hates this.

@nateynateynate nateynateynate merged commit aa28bcb into opensearch-project:main Apr 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants