Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change badge text to Experimental #101

Merged

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Nov 1, 2022

Description

Change documentation for beta badge text from "beta" to "experimental" as per #93

2022-11-01 10_43_19-Badge - OpenSearch UI Framework

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@BSFishy BSFishy requested a review from a team as a code owner November 1, 2022 17:44
@ashwin-pc
Copy link
Member

Shouldn't we rename the the term "Beta badge" to "Experimental badge" ?

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Nov 23, 2022 via email

@ashwin-pc
Copy link
Member

Ah got it, non breaking was the key word. Thanks :)

@rednaksi91 rednaksi91 merged commit 623d7be into opensearch-project:main Dec 15, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 15, 2022
Signed-off-by: Matt Provost <[email protected]>

Signed-off-by: Matt Provost <[email protected]>
(cherry picked from commit 623d7be)
@BSFishy BSFishy self-assigned this Dec 16, 2022
BSFishy added a commit that referenced this pull request Dec 20, 2022
Signed-off-by: Matt Provost <[email protected]>

Signed-off-by: Matt Provost <[email protected]>
(cherry picked from commit 623d7be)

Co-authored-by: Matt Provost <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants