Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coalesce PPL command #609

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Add coalesce PPL command #609

merged 5 commits into from
Sep 13, 2024

Conversation

salyh
Copy link
Contributor

@salyh salyh commented Aug 29, 2024

Description

Add coalesce PPL command

Issues Resolved

#519

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@salyh
Copy link
Contributor Author

salyh commented Aug 29, 2024

Will need to add tests and readme

@YANG-DB
Copy link
Member

YANG-DB commented Aug 30, 2024

@salyh plz update branch to resolve latest merge conflict
thanks

@salyh
Copy link
Contributor Author

salyh commented Aug 30, 2024

Done. Now you can use it as a function like eval c=coalesce('a','b')

@salyh
Copy link
Contributor Author

salyh commented Aug 30, 2024

If that looks good to you I will add tests and docs

@LantaoJin
Copy link
Member

If that looks good to you I will add tests and docs

Yes, I think so.

Copy link
Member

@YANG-DB YANG-DB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add tests for this functionality ?
and also please update the README with an example query

@YANG-DB
Copy link
Member

YANG-DB commented Sep 11, 2024

@salyh plz fix the Developer Certificate of Origin Check ...

@salyh
Copy link
Contributor Author

salyh commented Sep 12, 2024

@salyh plz fix the Developer Certificate of Origin Check ...

fixed

@YANG-DB
Copy link
Member

YANG-DB commented Sep 12, 2024

sorry - @lukasz-soszynski-eliatra can u plz rebase and merge the conflicts ?
its probably due to the latest merge ...
Thanks

salyh and others added 3 commits September 13, 2024 10:17
Signed-off-by: Hendrik Saly <[email protected]>
Signed-off-by: Hendrik Saly <[email protected]>
@lukasz-soszynski-eliatra
Copy link
Contributor

Done

@YANG-DB YANG-DB merged commit c6b388a into opensearch-project:main Sep 13, 2024
4 checks passed
@opensearch-trigger-bot
Copy link

The backport to 0.5 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.5 0.5
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.5
# Create a new branch
git switch --create backport/backport-609-to-0.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c6b388a99b25a635e0cd80081fa9ed9292533395
# Push it to GitHub
git push --set-upstream origin backport/backport-609-to-0.5
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.5

Then, create a pull request where the base branch is 0.5 and the compare/head branch is backport/backport-609-to-0.5.

@opensearch-trigger-bot
Copy link

The backport to 0.5-nexus failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.5-nexus 0.5-nexus
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.5-nexus
# Create a new branch
git switch --create backport/backport-609-to-0.5-nexus
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c6b388a99b25a635e0cd80081fa9ed9292533395
# Push it to GitHub
git push --set-upstream origin backport/backport-609-to-0.5-nexus
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.5-nexus

Then, create a pull request where the base branch is 0.5-nexus and the compare/head branch is backport/backport-609-to-0.5-nexus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants