Fix shutdown bug due to non-daemon thread in driver #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to opensearch-project#175, this PR adds shutdown logic in FlintJob. Tests: * Verified in IT if terminateJVM is enabled, JVM would shut down. Signed-off-by: Kaituo Li <[email protected]>
kaituo
requested review from
dai-chen,
rupal-bq,
vamsimanohar,
penghuo,
anirudha and
YANG-DB
as code owners
dai-chen
approved these changes
Mar 21, 2024
| @@ -34,6 +34,8 @@ trait FlintJobExecutor { | |||
| var threadPoolFactory: ThreadPoolFactory = new DefaultThreadPoolFactory() | |||
| var envinromentProvider: EnvironmentProvider = new RealEnvironment() | |||
| var enableHiveSupport: Boolean = true | |||
| // termiante JVM in the presence non-deamon thread before exiting | |||
| var terminateJVM = true | |||
There was a problem hiding this comment.
so this variable is only for test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #175, this PR adds shutdown logic in FlintJob.
Tests:
Issues Resolved
#270
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.