Improve exception unwrapping flexibility for SdkClientUtils #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
force-pushed
the
index-not-found
branch
2 times, most recently
from
6e3ded1 to
8f69d83
Compare
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
index-not-found
branch
2 times, most recently
from
37a6526 to
7b39494
Compare
| // Unwrap completion exception or pass through other exceptions | ||
| Throwable cause = throwable instanceof CompletionException ? throwable.getCause() : throwable; | ||
| @SafeVarargs | ||
| public static Exception unwrapAndConvertToException(Throwable throwable, Class<? extends Throwable>... exceptionTypesToUnwrap) { |
There was a problem hiding this comment.
Create a new method which takes in exceptionTypesToUnwrap to ensure backward compatibility.
There was a problem hiding this comment.
It's a varargs argument. It can be left blank, which is automatically creates an empty array, which is handled below with the default.
arjunkumargiri
approved these changes
Feb 5, 2025
dbwiddis
force-pushed
the
index-not-found
branch
from
7b39494 to
5dd1e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to unwrap from any of an optional list of exception types rather than just
CompletionException.So this usage:
would unwrap the cause of an
OpenSearchStatusException.Issues Resolved
Allows keeping existing code based on
IndexNotFoundExceptionto remain unchanged.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.