Use async NodeClient APIs for LocalClusterIndicesClient #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dhrubo-os
reviewed
Jan 15, 2025
core/src/main/java/org/opensearch/remote/metadata/client/impl/LocalClusterIndicesClient.java
Show resolved
Hide resolved
dhrubo-os
reviewed
Jan 15, 2025
...src/test/java/org/opensearch/remote/metadata/client/impl/LocalClusterIndicesClientTests.java
Show resolved
Hide resolved
Signed-off-by: Daniel Widdis <[email protected]>
dhrubo-os
approved these changes
Jan 16, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Use async NodeClient APIs for LocalClusterIndicesClient Signed-off-by: Daniel Widdis <[email protected]> * Fix handling of null vs. isExists on get Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit c86d3c5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Use async NodeClient APIs for LocalClusterIndicesClient * Fix handling of null vs. isExists on get --------- (cherry picked from commit c86d3c5) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes LocalClusterIndicesClient to use Async NodeClient APIs, completely ignoring the executor/threadpool
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.