Skip to content

Commit

Permalink
Revert "Switch publication to shadow JAR and add build script (#29)" (#…
Browse files Browse the repository at this point in the history
…43) (#44)

This reverts commit 1ce5e78.


(cherry picked from commit a975717)

Signed-off-by: Dhrubo Saha <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
1 parent b629311 commit eb9271b
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 107 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish-snapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ jobs:
export SONATYPE_PASSWORD=$(aws secretsmanager get-secret-value --secret-id maven-snapshots-password --query SecretString --output text)
echo "::add-mask::$SONATYPE_USERNAME"
echo "::add-mask::$SONATYPE_PASSWORD"
./gradlew publishShadowPublicationToSnapshotsRepository
./gradlew publishMavenJavaPublicationToSnapshotsRepository
5 changes: 0 additions & 5 deletions aos-client/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,3 @@ dependencies {
implementation("software.amazon.awssdk:url-connection-client")
implementation("software.amazon.awssdk:utils")
}

shadowJar {
dependsOn(':opensearch-remote-metadata-sdk-core:shadowJar',
':opensearch-remote-metadata-sdk-remote-client:shadowJar')
}
24 changes: 4 additions & 20 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ allprojects {

subprojects {
apply plugin: 'java-library'
apply plugin: 'com.github.johnrengelman.shadow'

dependencies {
// Common dependencies for all subprojects
Expand All @@ -108,8 +107,6 @@ subprojects {

configurations {
testImplementation.extendsFrom testFixtures
implementation.extendsFrom shadowImplementation
runtimeOnly.extendsFrom shadowRuntimeOnly
}

test {
Expand Down Expand Up @@ -148,11 +145,6 @@ subprojects {
withJavadocJar()
}

shadowJar {
archiveClassifier.set(null)
mergeServiceFiles()
}

checkstyle {
toolVersion = "10.21.1"
}
Expand All @@ -164,26 +156,18 @@ subprojects {

publishing {
publications {
shadow(MavenPublication) {
mavenJava(MavenPublication) {
from components.java

project.shadow.component(it)
// These are for unpublished test classes
suppressPomMetadataWarningsFor('testFixturesApiElements')
suppressPomMetadataWarningsFor('testFixturesRuntimeElements')

// Customize artifact ID for core project
if (project.name == 'opensearch-remote-metadata-sdk-core') {
artifactId = 'opensearch-remote-metadata-sdk'
}

artifacts.clear()

artifact shadowJar
artifact sourcesJar
artifact javadocJar

// These are for unpublished test classes
suppressPomMetadataWarningsFor('testFixturesApiElements')
suppressPomMetadataWarningsFor('testFixturesRuntimeElements')

pom {
name = project.name == 'opensearch-remote-metadata-sdk-core'
? "OpenSearch Remote Metadata SDK for Java"
Expand Down
2 changes: 2 additions & 0 deletions core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,5 @@ java {
dependencies {
testFixturesImplementation "org.opensearch:opensearch:${opensearch_version}"
}


6 changes: 0 additions & 6 deletions ddb-client/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,3 @@ dependencies {
implementation(platform("software.amazon.awssdk:bom:${aws_sdk_version}"))
implementation "software.amazon.awssdk:dynamodb"
}

shadowJar {
dependsOn(':opensearch-remote-metadata-sdk-core:shadowJar',
':opensearch-remote-metadata-sdk-remote-client:shadowJar',
':opensearch-remote-metadata-sdk-aos-client:shadowJar')
}
4 changes: 0 additions & 4 deletions remote-client/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,3 @@ dependencies {

implementation "org.opensearch.client:opensearch-java:${opensearch_java_version}"
}

shadowJar {
dependsOn(':opensearch-remote-metadata-sdk-core:shadowJar')
}
71 changes: 0 additions & 71 deletions scripts/build.sh

This file was deleted.

0 comments on commit eb9271b

Please sign in to comment.