#3530 enhance sanity testing framework #958

samuelcostae · 2023-11-21T13:55:50Z

Description

Enhanced Sanity Tests

Issues Resolved

#3530

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sam <[email protected]>

samuelcostae · 2023-11-30T15:46:23Z

@DarshitChanpura the tests are basically done, but based on the clarification on the issue discussion, i still have to replace the actual calls to the backend with mock responses.

I'm moving this out of draft without having complete that step I can get any feedback on the overall structure of the tests

cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js

Signed-off-by: Sam <[email protected]>

samuelcostae · 2023-12-05T15:52:16Z

@DarshitChanpura can you review this and let me know your thoughts? thanks

samuelcostae · 2023-12-18T12:28:37Z

@DarshitChanpura friendly ping

DarshitChanpura

LGTM

DarshitChanpura · 2024-01-10T16:31:17Z

Could we get some maintainer reviews on this?

In the latest CI run, cy.wait didn't seem to have caused any issues

ruanyl · 2024-01-30T03:23:22Z

@samuelcostae should this backport to 2.x?

DarshitChanpura · 2024-01-30T16:07:05Z

@samuelcostae should this backport to 2.x?

yes.

DarshitChanpura · 2024-03-05T20:12:38Z

@SuZhou-Joe @xluo-aws @Hailong-am @ruanyl @wanglam @raintygao Can we get some reviews on this PR? Last update was more than a month ago.

cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js

Check if pattern was acually created Signed-off-by: Sam <[email protected]>

…mework' into #3530_Enhance_sanity_testing_framework

Hailong-am · 2024-03-08T07:43:37Z

@samuelcostae would you mind paste local run result? The CI flow not running for the security-dashbaord-plugin and create an issue to track #1139

samuelcostae · 2024-03-08T09:03:23Z

@samuelcostae would you mind past local run result? The CI flow not running for the security-dashbaord-plugin and create an issue to track #1139

  OpenSearch Dashboards Security Plugin - Enhanced Sanity Tests
    ✓ should create new tenant successfully by selecting `Create tenant` (19060ms)
    ✓ should create a new internal user (6521ms)
    ✓ should create a new role with specific permissions (17944ms)
    ✓ should add a new role mapping
    ✓ should create a new index pattern (58404ms)


  5 passing (2m)

DarshitChanpura · 2024-03-11T17:01:31Z

@SuZhou-Joe @xluo-aws @ruanyl @wanglam @raintygao Can we get 1 more review on this PR?

DarshitChanpura · 2024-03-15T17:01:17Z

@SuZhou-Joe @xluo-aws @ruanyl @wanglam @raintygao Can we get 1 more review on this PR please?

DarshitChanpura · 2024-03-15T17:03:38Z

@davidlago @wbeckler can you please help get this unblocked?

samuelcostae · 2024-03-20T11:10:16Z

@davidlago @wbeckler can you please help get this unblocked?

@davidlago @wbeckler Just a friendly ping for a second review.

Let us know any further work is required.

DarshitChanpura · 2024-03-20T15:11:06Z

@SuZhou-Joe @xluo-aws @ruanyl @wanglam @raintygao Pinging for 1 more review on this PR please.

DarshitChanpura · 2024-03-26T17:04:28Z

@SuZhou-Joe @xluo-aws @ruanyl @wanglam @raintygao Pinging for 1 more review on this PR please. This has been lingering for more than 2 weeks now.

* initial skeleton Signed-off-by: Sam <[email protected]> * first two sections Signed-off-by: Sam <[email protected]> * first two sections Signed-off-by: Sam <[email protected]> * index pattern creation Signed-off-by: Sam <[email protected]> * index pattern creation Signed-off-by: Sam <[email protected]> * Bug Fixes Signed-off-by: Sam <[email protected]> * Cleanup Signed-off-by: Sam <[email protected]> * Cleanup Signed-off-by: Sam <[email protected]> * Cleanup Signed-off-by: Sam <[email protected]> * Refactor Signed-off-by: Sam <[email protected]> * Comment/ Extra line removal Signed-off-by: Sam <[email protected]> * Using loadSampleData command instead of custom method. Check if pattern was acually created Signed-off-by: Sam <[email protected]> --------- Signed-off-by: Sam <[email protected]> (cherry picked from commit e1e0716)

kavilla · 2024-04-02T07:51:57Z

One comment is that we should consider on cleaning up the addition of the sample data within the test itself. Otherwise it leaves the cluster in a dirty state and could case the next test to fail.

I would also verify that the expected test index isn't already existing to avoid transient failures.

@samuelcostae

* initial skeleton Signed-off-by: Sam <[email protected]> * first two sections Signed-off-by: Sam <[email protected]> * first two sections Signed-off-by: Sam <[email protected]> * index pattern creation Signed-off-by: Sam <[email protected]> * index pattern creation Signed-off-by: Sam <[email protected]> * Bug Fixes Signed-off-by: Sam <[email protected]> * Cleanup Signed-off-by: Sam <[email protected]> * Cleanup Signed-off-by: Sam <[email protected]> * Cleanup Signed-off-by: Sam <[email protected]> * Refactor Signed-off-by: Sam <[email protected]> * Comment/ Extra line removal Signed-off-by: Sam <[email protected]> * Using loadSampleData command instead of custom method. Check if pattern was acually created Signed-off-by: Sam <[email protected]> --------- Signed-off-by: Sam <[email protected]> (cherry picked from commit e1e0716)

* initial skeleton Signed-off-by: Sam <[email protected]> * first two sections Signed-off-by: Sam <[email protected]> * first two sections Signed-off-by: Sam <[email protected]> * index pattern creation Signed-off-by: Sam <[email protected]> * index pattern creation Signed-off-by: Sam <[email protected]> * Bug Fixes Signed-off-by: Sam <[email protected]> * Cleanup Signed-off-by: Sam <[email protected]> * Cleanup Signed-off-by: Sam <[email protected]> * Cleanup Signed-off-by: Sam <[email protected]> * Refactor Signed-off-by: Sam <[email protected]> * Comment/ Extra line removal Signed-off-by: Sam <[email protected]> * Using loadSampleData command instead of custom method. Check if pattern was acually created Signed-off-by: Sam <[email protected]> --------- Signed-off-by: Sam <[email protected]>

* initial skeleton Signed-off-by: Sam <[email protected]> * first two sections Signed-off-by: Sam <[email protected]> * first two sections Signed-off-by: Sam <[email protected]> * index pattern creation Signed-off-by: Sam <[email protected]> * index pattern creation Signed-off-by: Sam <[email protected]> * Bug Fixes Signed-off-by: Sam <[email protected]> * Cleanup Signed-off-by: Sam <[email protected]> * Cleanup Signed-off-by: Sam <[email protected]> * Cleanup Signed-off-by: Sam <[email protected]> * Refactor Signed-off-by: Sam <[email protected]> * Comment/ Extra line removal Signed-off-by: Sam <[email protected]> * Using loadSampleData command instead of custom method. Check if pattern was acually created Signed-off-by: Sam <[email protected]> --------- Signed-off-by: Sam <[email protected]> (cherry picked from commit e1e0716)

samuelcostae added 2 commits November 21, 2023 14:01

initial skeleton

6618236

Signed-off-by: Sam <[email protected]>

first two sections

03187b8

Signed-off-by: Sam <[email protected]>

samuelcostae force-pushed the #3530_Enhance_sanity_testing_framework branch from 1060c69 to 03187b8 Compare November 21, 2023 14:02

samuelcostae added 4 commits November 23, 2023 01:04

first two sections

801906f

Signed-off-by: Sam <[email protected]>

index pattern creation

a216753

Signed-off-by: Sam <[email protected]>

index pattern creation

171c3c8

Signed-off-by: Sam <[email protected]>

Bug Fixes

5299062

Signed-off-by: Sam <[email protected]>

samuelcostae marked this pull request as ready for review November 30, 2023 14:53

samuelcostae requested review from xluo-aws, Hailong-am, SuZhou-Joe, ruanyl, wanglam and raintygao as code owners November 30, 2023 14:53

samuelcostae changed the title ~~DRAFT #3530 enhance sanity testing framework~~ #3530 enhance sanity testing framework Nov 30, 2023

Cleanup

0f0e944

Signed-off-by: Sam <[email protected]>

SuZhou-Joe reviewed Dec 1, 2023

View reviewed changes

cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js Outdated Show resolved Hide resolved

SuZhou-Joe reviewed Dec 1, 2023

View reviewed changes

cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js Outdated Show resolved Hide resolved

SuZhou-Joe reviewed Dec 1, 2023

View reviewed changes

cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js Outdated Show resolved Hide resolved

SuZhou-Joe reviewed Dec 1, 2023

View reviewed changes

cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js Outdated Show resolved Hide resolved

samuelcostae added 2 commits December 2, 2023 01:56

Cleanup

b1d4517

Signed-off-by: Sam <[email protected]>

Cleanup

f28dba4

Signed-off-by: Sam <[email protected]>

samuelcostae force-pushed the #3530_Enhance_sanity_testing_framework branch from b1d4517 to f28dba4 Compare December 2, 2023 02:23

samuelcostae and others added 3 commits December 4, 2023 18:47

Mocks

2997ee0

Signed-off-by: Sam <[email protected]>

Refactor

664bdc3

Signed-off-by: Sam <[email protected]>

Merge branch 'main' into #3530_Enhance_sanity_testing_framework

cd37d87

Merge branch 'main' into #3530_Enhance_sanity_testing_framework

085a4df

DarshitChanpura approved these changes Jan 10, 2024

View reviewed changes

DarshitChanpura mentioned this pull request Jan 18, 2024

[Testing] Enhance sanity testing framework opensearch-project/security#3530

Closed

2 tasks

ruanyl added the backport 2.x label Jan 31, 2024

Hailong-am reviewed Mar 6, 2024

View reviewed changes

cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js Outdated Show resolved Hide resolved

cypress/integration/plugins/security-dashboards-plugin/sanity_tests.spec.js Show resolved Hide resolved

samuelcostae and others added 3 commits March 6, 2024 13:57

Merge branch 'main' into #3530_Enhance_sanity_testing_framework

21cf156

Using loadSampleData command instead of custom method.

ff90f9d

Check if pattern was acually created Signed-off-by: Sam <[email protected]>

Merge remote-tracking branch 'myfork/#3530_Enhance_sanity_testing_fra…

19777f1

…mework' into #3530_Enhance_sanity_testing_framework

Hailong-am approved these changes Mar 8, 2024

View reviewed changes

Merge branch 'main' into #3530_Enhance_sanity_testing_framework

7b80723

ruanyl approved these changes Mar 28, 2024

View reviewed changes

SuZhou-Joe merged commit e1e0716 into opensearch-project:main Mar 28, 2024
84 checks passed

opensearch-trigger-bot bot mentioned this pull request Mar 28, 2024

[Backport 2.x] #3530 enhance sanity testing framework #1185

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#3530 enhance sanity testing framework #958

#3530 enhance sanity testing framework #958

samuelcostae commented Nov 21, 2023

samuelcostae commented Nov 30, 2023

samuelcostae commented Dec 5, 2023

samuelcostae commented Dec 18, 2023

DarshitChanpura left a comment

DarshitChanpura commented Jan 10, 2024

ruanyl commented Jan 30, 2024

DarshitChanpura commented Jan 30, 2024

DarshitChanpura commented Mar 5, 2024

Hailong-am commented Mar 8, 2024 •

edited

Loading

samuelcostae commented Mar 8, 2024 •

edited

Loading

DarshitChanpura commented Mar 11, 2024

DarshitChanpura commented Mar 15, 2024

DarshitChanpura commented Mar 15, 2024 •

edited

Loading

samuelcostae commented Mar 20, 2024

DarshitChanpura commented Mar 20, 2024

DarshitChanpura commented Mar 26, 2024

kavilla commented Apr 2, 2024 •

edited

Loading

#3530 enhance sanity testing framework #958

#3530 enhance sanity testing framework #958

Conversation

samuelcostae commented Nov 21, 2023

Description

Issues Resolved

Check List

samuelcostae commented Nov 30, 2023

samuelcostae commented Dec 5, 2023

samuelcostae commented Dec 18, 2023

DarshitChanpura left a comment

Choose a reason for hiding this comment

DarshitChanpura commented Jan 10, 2024

ruanyl commented Jan 30, 2024

DarshitChanpura commented Jan 30, 2024

DarshitChanpura commented Mar 5, 2024

Hailong-am commented Mar 8, 2024 • edited Loading

samuelcostae commented Mar 8, 2024 • edited Loading

DarshitChanpura commented Mar 11, 2024

DarshitChanpura commented Mar 15, 2024

DarshitChanpura commented Mar 15, 2024 • edited Loading

samuelcostae commented Mar 20, 2024

DarshitChanpura commented Mar 20, 2024

DarshitChanpura commented Mar 26, 2024

kavilla commented Apr 2, 2024 • edited Loading

Hailong-am commented Mar 8, 2024 •

edited

Loading

samuelcostae commented Mar 8, 2024 •

edited

Loading

DarshitChanpura commented Mar 15, 2024 •

edited

Loading

kavilla commented Apr 2, 2024 •

edited

Loading