Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Update FF test to integrate with new API calls #1700

Merged
merged 1 commit into from
Feb 7, 2025
Merged

[Backport 2.x] Update FF test to integrate with new API calls #1700

merged 1 commit into from
Feb 7, 2025
+188 −7

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c3255d5 from #1696

@ohltyler @github-actions
Update FF test to integrate with new API calls (#1696)
5f4f50b 
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit c3255d5)
@Hailong-am
Copy link
Collaborator

the CI still failing, can you double check?

@ohltyler
Copy link
Member

ohltyler commented Feb 7, 2025 •
edited
Loading

the CI still failing, can you double check?

Ran 2.19 against this exact branch, still cannot replicate the failure, it is passing. Will merge and run CIs from our plugin to check first.

Additionally, main CI in our plugin repo is passing now, after the main merge happened: https://github.com/opensearch-project/dashboards-flow-framework/actions/runs/13206049805/job/36869297747

My assumption is the CIs here are running against a bad/outdated cluster.

@ohltyler ohltyler merged commit d6f6e0c into 2.x Feb 7, 2025
39 of 41 checks passed
@ohltyler ohltyler deleted the backport/backport-1696-to-2.x branch February 7, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am approved these changes

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@yujin-emma yujin-emma Awaiting requested review from yujin-emma yujin-emma is a code owner

@yubonluo yubonluo Awaiting requested review from yubonluo yubonluo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hailong-am @ohltyler