Support -p platform in build scripts. #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dblock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #748 +/- ##
==========================================
+ Coverage 91.16% 91.17% +0.01%
==========================================
Files 75 75
Lines 1980 1984 +4
==========================================
+ Hits 1805 1809 +4
Misses 175 175
Continue to review full report at Codecov.
|
dblock
commented
Oct 14, 2021
| arch=None, | ||
| name=None, | ||
| snapshot=True, | ||
| build_id=None, | ||
| output_dir="artifacts", | ||
| ): | ||
| self.build_id = os.getenv("OPENSEARCH_BUILD_ID") or os.getenv("OPENSEARCH_DASHBOARDS_BUILD_ID") or build_id or uuid.uuid4().hex | ||
| self.build_id = os.getenv("BUILD_NUMBER") or build_id or uuid.uuid4().hex |
There was a problem hiding this comment.
Side effect of #730 that we forgot to fix.
There was a problem hiding this comment.
Yea, looks like those bundle numbers became 8c363d37f71349b1add343c0c48945a7
Signed-off-by: dblock <[email protected]>
peternied
approved these changes
Oct 14, 2021
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock [email protected]
Description
Support for #740, adds
-p platformto build scripts so we can passlinuxordarwinaround and default it touname -s. This required re-overwriting common-utils, job-scheduler and alerting scripts.ScriptFinder is incorrectly picking the override from the repo with source code. The build repo should be the one always picked first because that's where we'd make a last minute fix, updated.
Auto-resolving JAVA_HOME on MacOS.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.